chore(cm): changed the Configure the view link icon in the edit view #20274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuaellis
reviewed
May 7, 2024
packages/core/content-manager/admin/src/pages/EditView/components/Header.tsx
Outdated
Show resolved
Hide resolved
lucasboilly
added
pr: fix
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@joshuaellis I just dit it, I also removed the functions for the other icons and it seems to work well |
|
I think your IDE is not configured correctly with the lint & prettier, you need to resolve that before we can merge :) |
joshuaellis
changed the title
joshuaellis
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
It changes the Cog icon of the Configure the view link of the edit view to a ListPlus icon.
Why is it needed?
The edit view is currently the only page where we use the Cog icon to illustrate the Configure the view feature. In every other page we we use the ListPlus icon (my bad, the error comes from my mockups).
How to test it?
It can be seen in the edit view of any entry.
Related issue(s)/PR(s)
Not related to any issue or pull request.
CleanShot.2024-05-07.at.09.30.33.mp4