Update ESLint dependency #3647
Update ESLint dependency #3647
Conversation
| @@ -41,6 +41,7 @@ module.exports = { | |||
| rules: { | |||
| 'generator-star-spacing': 0, | |||
| 'no-console': 0, | |||
| 'require-atomic-updates': 0, | |||
There was a problem hiding this comment.
If anyone wants to remove this rule, go ahead!
|
@abdonrd your PR doesn't passes the tests... Can you fix them? |
|
@soupette ops! There is an issue with ESLint v6.2.0 with Pinned the ESLint v6.1.0 version should work now! I can send a new PR with this update when they release a new version with the fix. |
|
@soupette green no! 馃槃 |
|
It looks good for me but will need @alexandrebodin insight also since there are a lot of backend files that have been modified |
|
@alexandrebodin done! |
|
@abdonrd Thank you ! we will wait for the merging of th develop branch and update this branch to merge it ! |
lauriejim
added
pr: 馃拝 Enhancement
source: core:strapi
|
@abdonrd If you feel like updating this one ;) |
# Conflicts: # .eslintrc.js # package.json # packages/strapi-admin/admin/src/containers/HomePage/CommunityContent.js # packages/strapi-admin/admin/src/containers/HomePage/WelcomeContent.js # packages/strapi-helper-plugin/lib/src/components/InputTextWithErrors/index.js # packages/strapi-hook-bookshelf/lib/index.js # packages/strapi-hook-bookshelf/lib/utils/graphql.js # packages/strapi-hook-bookshelf/lib/utils/index.js # packages/strapi-plugin-content-manager/admin/src/components/FilterOptions/InputWithAutoFocus.js # packages/strapi-plugin-content-manager/admin/src/components/SelectMany/index.js # packages/strapi-plugin-content-manager/admin/src/components/SelectOne/index.js # packages/strapi-plugin-content-manager/admin/src/components/TableHeader/index.js # packages/strapi-plugin-content-manager/admin/src/containers/ListPage/index.js # packages/strapi-plugin-content-manager/admin/src/containers/SettingPage/index.js # packages/strapi-plugin-content-manager/config/policies/routing.js # packages/strapi-plugin-content-manager/services/ContentManager.js # packages/strapi-plugin-content-type-builder/admin/src/components/TableListRow/index.js # packages/strapi-plugin-content-type-builder/admin/src/containers/AttributesPickerModal/index.js # packages/strapi-utils/lib/models.js # yarn.lock
|
@alexandrebodin updated! |
|
@abdonrd a short yarn install should fix the last conflicts :) |
# Conflicts: # yarn.lock
|
@alexandrebodin done! |
Description of what you did:
Update ESLint dependency.
My PR is a:
Main update on the:
Manual testing done on the following databases: