fix: graphql fields not required during creation when model attribute has a default value #6075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a required attribute that has a default value it's now not required in the input schema used for entities creation Signed-off-by: Gadi Piperno Corcos <gadi@skyriseltd.com>
Codecov Report
@@ Coverage Diff @@
## master #6075 +/- ##
=======================================
Coverage 19.85% 19.85%
=======================================
Files 856 856
Lines 12046 12046
Branches 1950 1950
=======================================
Hits 2392 2392
Misses 8079 8079
Partials 1575 1575
Continue to review full report at Codecov.
|
alexandrebodin
approved these changes
Jul 16, 2020
alexandrebodin
added
source: plugin:graphql
gilfernandes
pushed a commit
to onepointconsulting/strapi
that referenced
this pull request
Aug 13, 2020
a required attribute that has a default value it's now not required in the input schema used for entities creation Signed-off-by: Gadi Piperno Corcos <gadi@skyriseltd.com> Co-authored-by: Gadi Piperno Corcos <gadi@skyriseltd.com> Signed-off-by: Gil Fernandes <gil.fernandes@onepointltd.com>
This was referenced Jun 6, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what you did:
Changed the graphql type builder behaviour for required attributes:
a required attribute that has a default value now is not required in the input schema used for entities creation