Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Russian translation for Media Library #6167

Merged
merged 14 commits into from Jun 18, 2020
Merged

Conversation

alxnkt
Copy link
Contributor

@alxnkt alxnkt commented May 11, 2020

Description of what you did:

Created Russian translation for Media Library plugin, including Administration plugin side menu link.

Signed-off-by: alxnkt <alxnkt@mail.ru>
@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #6167 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6167   +/-   ##
=======================================
  Coverage   19.98%   19.98%           
=======================================
  Files         858      858           
  Lines       12098    12098           
  Branches     1965     1965           
=======================================
  Hits         2418     2418           
  Misses       8095     8095           
  Partials     1585     1585           
Flag Coverage Δ
#front 14.67% <ø> (ø)
#unit 41.71% <ø> (ø)
Impacted Files Coverage Δ
...rapi-plugin-upload/admin/src/translations/index.js 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d864c2c...1461aa9. Read the comment docs.

soupette
soupette previously approved these changes May 26, 2020
Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks a lot for taking the time to contribute

Signed-off-by: alxnkt <49128174+alxnkt@users.noreply.github.com>
@alxnkt alxnkt force-pushed the mlrus branch 2 times, most recently from 3ac1ad0 to 687158e Compare June 16, 2020 15:03
soupette
soupette previously approved these changes Jun 17, 2020
Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for your contribution

@soupette
Copy link
Contributor

@alxnkt thanks for your contribution can make sure the DCO checks so we can merge your PR?

@soupette soupette added source: core:admin Source is core/admin package issue: enhancement Issue suggesting an enhancement to an existing feature labels Jun 17, 2020
@soupette soupette added this to the 3.0.3 milestone Jun 17, 2020
Signed-off-by: alxnkt <49128174+alxnkt@users.noreply.github.com>
Signed-off-by: alxnkt <alxnkt@mail.ru>
alxnkt and others added 3 commits June 18, 2020 10:40
@alxnkt
Copy link
Contributor Author

alxnkt commented Jun 18, 2020

Oh, my fault. Sorry.
Just added my sign-off information (followed instructions), but DCO check still fails. ☹️

alxnkt and others added 2 commits June 18, 2020 12:04
Signed-off-by: alxnkt <alxnkt@mail.ru>
Signed-off-by: alxnkt <alxnkt@mail.ru>
@alexandrebodin alexandrebodin merged commit f10b4db into strapi:master Jun 18, 2020
@alxnkt alxnkt deleted the mlrus branch June 20, 2020 13:49
iicdii pushed a commit to iicdii/strapi that referenced this pull request Jul 2, 2020
* Signoff (Russian translation)

Signed-off-by: alxnkt <alxnkt@mail.ru>

* New line at the end of index.js file

* Minor changes for plurals

Signed-off-by: alxnkt <alxnkt@mail.ru>

Co-authored-by: cyril lopez <cyril.lpz@gmail.com>
Signed-off-by: harimkims <harimkims@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants