New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation of the section plugin Google Cloud Storage #6275
Conversation
bd3dbaa
to
880e2dd
Compare
While I do like gutting this out, @lauriejim we need to clarify if we are going to be directly linking community plugins in the official documentation. (Or at the very least we should probably make a notice that this plugin is not developed by Strapi) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, but need Jim to approve and/or maybe add a notice about it not being managed by Strapi.
Hi @derrickmehaffy , thanks for your fast reply. I've wrote from the beginning on the documentation of the plugin, it's a "Non-Official" Google Cloud Storage Provider for Strapi Upload. The main problem for now, it's some user send me help request for Google App Engine and how to use the plugin with deprecated information. Thanks :) |
Ah yeah perfect, I hadn't reviewed the other part of that documentation. I am certainly not apposed to having community packages in the docs. :) |
@Lith |
Codecov Report
@@ Coverage Diff @@
## master #6275 +/- ##
=======================================
Coverage 19.85% 19.85%
=======================================
Files 857 857
Lines 12076 12076
Branches 1963 1963
=======================================
Hits 2398 2398
Misses 8093 8093
Partials 1585 1585
Continue to review full report at Codecov.
|
Hi, I've fixed conflict and rebase to latest master commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I would prefer directly linking to the source as it's easier for @Lith to maintain as apposed to updating the documentation.
Travis are failing with MySQL. Does it possible to check and approve this PR ? |
You can ignore that, since you are modifying the docs. It has to do with the knex pooling.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hello @Lith can you please also apply this update in the |
178cfc0
to
931647a
Compare
Signed-off-by: Vanessa Pasque (Lith) <lith@amykron.com>
931647a
to
2b6ff54
Compare
Hi @lauriejim ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect thank you @Lith
Hello,
Some people are writing issue about misunderstood in the
google cloud storage
section for the deployment with Google App Engine.In order to avoid further mistake, I prefer than the documentation provide a redirection to the full documentation of the plugin.
Thanks,