New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ENV to allow hiding startup message #6348
Add ENV to allow hiding startup message #6348
Conversation
Signed-off-by: Peter Baričič <pbaricic@gmail.com>
c98f580
to
1ea12a3
Compare
@alexandrebodin @lauriejim maybe we need to make a place on the documentation to cover any existing environment variables in use? (For example the JWT_SECRET) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Internal env var should start with STRAPI
.
Codecov Report
@@ Coverage Diff @@
## master #6348 +/- ##
==========================================
- Coverage 19.99% 19.98% -0.01%
==========================================
Files 858 858
Lines 12095 12094 -1
Branches 1965 1965
==========================================
- Hits 2418 2417 -1
Misses 8092 8092
Partials 1585 1585
Continue to review full report at Codecov.
|
Signed-off-by: Peter Baričič <peter.baricic@naytrolabs.com>
3aae2f7
to
a629e69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should revert the logic. The message should be displayed by default.
Signed-off-by: Peter Baričič <pbaricic@gmail.com>
981be8b
to
ab0b1e1
Compare
why is travis always failing on E2E mysql (full pool)? |
You can ignore this for now, work is being done to try and solve this not only in tests but user projects as well (some default options I believe are set too low) |
Hi @peterbaricic would you mind working on adding this var to the documentation ? @lauriejim Can you tell us where you would put these docs ? |
Sure, I can add it, just please point me to the right docs :-) |
Hello and sorry for the delay.
Having a table like this could be a good option. |
Signed-off-by: Peter Baričič <pbaricic@gmail.com>
4ae613c
to
408eaee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for the addon !
Eventually I think we should replace the console logs with strapi logger so you can disable all the logs at once too
* Add ENV to allow hiding startup message Signed-off-by: Peter Baričič <pbaricic@gmail.com> * Rename ENV Signed-off-by: Peter Baričič <peter.baricic@naytrolabs.com> * Revert the logic Signed-off-by: Peter Baričič <pbaricic@gmail.com> * Update docs with startup ENVs Signed-off-by: Peter Baričič <pbaricic@gmail.com> Co-authored-by: Peter Baričič <peter.baricic@naytrolabs.com> Co-authored-by: Alexandre BODIN <alexandrebodin@users.noreply.github.com> Signed-off-by: Gil Fernandes <gil.fernandes@onepointltd.com>
Hi,
our devops team wanted me to disable the startup message, but because there is no way to turn it off, I added an ENV
STRAPI_HIDE_STARTUP_MESSAGE
to allow user to hide the startup message.I would also update the docs, but there is no documentation currently mentioning any existing logging ENVs like STRAPI_LOG_LEVEL, STRAPI_LOG_PRETTY_PRINT, STRAPI_LOG_FORCE_COLOR and STRAPI_LOG_TIMESTAMP.