Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Malay(ms.json) Translation #6394

Merged
merged 22 commits into from Jun 11, 2020
Merged

Add Malay(ms.json) Translation #6394

merged 22 commits into from Jun 11, 2020

Conversation

fadhilx
Copy link
Contributor

@fadhilx fadhilx commented May 27, 2020

  • Add Malay(ms.json) translation for
    • strapi-admin
    • strapi-generate-plugin
    • strapi-plugin-content-manager
    • strapi-plugin-content-type-manager
    • strapi-plugin-documentation
    • strapi-plugin-email
    • strapi-plugin-upload
    • strapi-plugin-users-permission
  • Create file translations/ms.json on every plugin
  • Update translations/index.js adding ms.json
  • Add flag of Malaysia(my.svg) on LocaleToggle component in strapi-admin

fadhilx and others added 11 commits May 28, 2020 01:10
@fadhilx
feat: add malay translation for strapi-admin
8bd3a59 
Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>
@fadhilx
feat: add malay locale on strapi-generate-plugin
d27b8f3 
Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>
@fadhilx
feat: add malay translation for content-manager
6eb4dce 
Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>
@fadhilx
feat: add malay translation for content-type-builder
056100d 
Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>
@fadhilx
faet: add malay translation for strapi-plugin-documentation
ebd57e1 
Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>
@fadhilx
feat: add malay translation for email plugin
1ee2847 
Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>
@fadhilx
feat: add malay translation on upload plugin
a7eb7fc 
Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>
@fadhilx
feat: add malay translation for permission plugin
e70587b 
Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>
@alexandrebodin @fadhilx
Fix language middleware (strapi#6387)
83d5c95 
Signed-off-by: Alexandre Bodin <bodin.alex@gmail.com>
Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>
@ScottAgirs @fadhilx
[typo] Persmissions > Permissions (strapi#6390)
77e569a 
Signed-off-by: ScottAgirs <scott@ijs.to>
Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>
@fadhilx
refactor: fix typo, suitable word and grammar
386bb96 
Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>
@fadhilx
test: add ms test
ae4ddc0 
Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>
@fadhilx fadhilx changed the title [WIP] Add Malay Translation Add Malay Translation May 27, 2020
@fadhilx fadhilx changed the title Add Malay Translation Add Malay(ms.json) Translation May 27, 2020
@codecov
Copy link

codecov bot commented May 29, 2020 •
edited

Codecov Report

Merging #6394 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6394   +/-   ##
=======================================
  Coverage   19.85%   19.86%           
=======================================
  Files         857      857           
  Lines       12076    12077    +1     
  Branches     1963     1963           
=======================================
+ Hits         2398     2399    +1     
  Misses       8093     8093           
  Partials     1585     1585
Flag Coverage Δ
#front 14.67% <100.00%> (+<0.01%) ⬆️
#unit 41.26% <ø> (ø)
Impacted Files Coverage Δ
...kages/strapi-admin/admin/src/translations/index.js 100.00% <ø> (ø)
...in-content-manager/admin/src/translations/index.js 0.00% <ø> (ø)
...ntent-type-builder/admin/src/translations/index.js 0.00% <ø> (ø)
...ugin-documentation/admin/src/translations/index.js 0.00% <ø> (ø)
...trapi-plugin-email/admin/src/translations/index.js 0.00% <ø> (ø)
...rapi-plugin-upload/admin/src/translations/index.js 0.00% <ø> (ø)
...-users-permissions/admin/src/translations/index.js 0.00% <ø> (ø)
...i-admin/admin/src/containers/LocaleToggle/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aec77b1...26cb907. Read the comment docs.

@fadhilx fadhilx force-pushed the admin/translation-ms branch 2 times, most recently from 21451a5 to eb5a798 Compare May 29, 2020 15:00
@fadhilx
fix: typos on plugin.description email
7b0a69b 
Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>
soupette
soupette approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for taking the time to contribute to the project!

@soupette soupette added this to the 3.0.2 milestone Jun 1, 2020
@soupette soupette added source: core:admin Source is core/admin package source: core:content-manager Source is core/content-manager package source: core:content-type-builder Source is core/content-type-builder package source: plugin:documentation Source is plugin/documentation package source: plugin:graphql Source is plugin/graphql package source: core:email Source is core/email package source: core:upload Source is core/upload package source: plugin:users-permissions Source is plugin/users-permissions package issue: enhancement Issue suggesting an enhancement to an existing feature labels Jun 1, 2020
@alexandrebodin alexandrebodin merged commit 7123a11 into strapi:master Jun 11, 2020
iicdii pushed a commit to iicdii/strapi that referenced this pull request Jul 2, 2020
@fadhilx @alexandrebodin
@ScottAgirs @soupette @iicdii
Add Malay(ms.json) Translation (strapi#6394)
0a7cfc0 
* feat: add malay  translation for strapi-admin

Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>

* feat: add malay locale on strapi-generate-plugin

Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>

* feat: add malay translation for content-manager

Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>

* feat: add malay translation for content-type-builder

Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>

* faet: add malay translation for strapi-plugin-documentation

Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>

* feat: add malay translation for email plugin

Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>

* feat: add malay translation on upload plugin

Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>

* feat: add malay translation for permission plugin

Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>

* Fix language middleware (strapi#6387)

Signed-off-by: Alexandre Bodin <bodin.alex@gmail.com>
Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>

* [typo] Persmissions > Permissions (strapi#6390)

Signed-off-by: ScottAgirs <scott@ijs.to>
Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>

* refactor: fix typo, suitable word and grammar

Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>

* test: add ms test

Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>

* fix: typos on plugin.description email

Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>

Co-authored-by: Alexandre BODIN <alexandrebodin@users.noreply.github.com>
Co-authored-by: Scott Agirs <ScottAgirs@users.noreply.github.com>
Co-authored-by: cyril lopez <cyril.lpz@gmail.com>
Signed-off-by: harimkims <harimkims@gmail.com>
This was referenced Jun 6, 2021
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soupette soupette soupette approved these changes

Assignees
No one assigned
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:admin Source is core/admin package source: core:content-manager Source is core/content-manager package source: core:content-type-builder Source is core/content-type-builder package source: core:email Source is core/email package source: core:upload Source is core/upload package source: plugin:documentation Source is plugin/documentation package source: plugin:graphql Source is plugin/graphql package source: plugin:users-permissions Source is plugin/users-permissions package
Projects
None yet
Milestone
3.0.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fadhilx @soupette @alexandrebodin @ScottAgirs