Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lifecycle hooks URL #6417

Merged
merged 1 commit into from May 29, 2020
Merged

Fix lifecycle hooks URL #6417

merged 1 commit into from May 29, 2020

Conversation

abdonrd
Copy link
Contributor

@abdonrd abdonrd commented May 28, 2020

Description of what you did:

Fix lifecycle hooks URL

@codecov
Copy link

codecov bot commented May 28, 2020 •
edited

Codecov Report

Merging #6417 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6417   +/-   ##
=======================================
  Coverage   19.86%   19.86%           
=======================================
  Files         856      856           
  Lines       12071    12071           
  Branches     1961     1961           
=======================================
  Hits         2398     2398           
  Misses       8090     8090           
  Partials     1583     1583
Flag Coverage Δ
#front 14.67% <ø> (ø)
#unit 41.26% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b64e05...231533e. Read the comment docs.

@alexandrebodin
Copy link
Member

Hi @abdonrd can you check the DCO issue ? :)

@abdonrd
Update model.template
231533e 
Signed-off-by: Abdón Rodríguez Davila <a@abdonrd.com>
@abdonrd
Copy link
Contributor Author

abdonrd commented May 29, 2020

Done!

@alexandrebodin alexandrebodin added this to the 3.0.2 milestone May 29, 2020
@alexandrebodin alexandrebodin added source: core:strapi Source is core/strapi package issue: enhancement Issue suggesting an enhancement to an existing feature labels May 29, 2020
@alexandrebodin alexandrebodin self-requested a review May 29, 2020 09:12
alexandrebodin
alexandrebodin approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@alexandrebodin alexandrebodin merged commit e5d3b39 into strapi:master May 29, 2020
@abdonrd abdonrd deleted the patch-2 branch May 29, 2020 09:54
This was referenced Jun 6, 2021
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrebodin alexandrebodin alexandrebodin approved these changes

Assignees
No one assigned
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:strapi Source is core/strapi package
Projects
None yet
Milestone
3.0.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abdonrd @alexandrebodin