Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translation support on 'users-permissions' , 'upload' and 'content-manager' plugin #6439

Merged

Conversation

fadhilx
Copy link
Contributor

@fadhilx fadhilx commented May 29, 2020

What i did:

  • Add translation support for Enabled and Disabled on strapi-plugin-users-permissions
    image
  • Add translation support for Replace Media on strapi-plugin-upload
    image
  • Add translation support for Component is Required on strapi-plugin-content-manager
    image

@fadhilx fadhilx marked this pull request as draft May 29, 2020 19:29
@fadhilx fadhilx changed the title Add Enable, Disable, and Done trad on email plugin [Add translation support on Enable, Disable on email plugin May 29, 2020
@fadhilx fadhilx changed the title [Add translation support on Enable, Disable on email plugin [WIP] Add translation support on Enable, Disable on email plugin May 29, 2020
@fadhilx fadhilx changed the title [WIP] Add translation support on Enable, Disable on email plugin [WIP] Add translation support on Enabled, Disabled on email plugin May 29, 2020
Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>
Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>
…done on strapi-admin

Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>
Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>
@fadhilx fadhilx force-pushed the plugin-email/translate-provider-n-modal branch from 5106511 to 21bbcfb Compare May 30, 2020 03:36
@fadhilx fadhilx changed the title [WIP] Add translation support on Enabled, Disabled on email plugin Update translation support on 'permission' plugin, 'upload' plugin and 'dynamic zone' component May 30, 2020
@fadhilx fadhilx marked this pull request as ready for review May 30, 2020 03:44
@fadhilx fadhilx changed the title Update translation support on 'permission' plugin, 'upload' plugin and 'dynamic zone' component Update translation support on 'users-permissions' , 'upload' and 'content-manager' plugin May 30, 2020
@codecov
Copy link

codecov bot commented May 30, 2020

Codecov Report

Merging #6439 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6439   +/-   ##
=======================================
  Coverage   19.85%   19.86%           
=======================================
  Files         857      857           
  Lines       12076    12077    +1     
  Branches     1963     1963           
=======================================
+ Hits         2398     2399    +1     
  Misses       8093     8093           
  Partials     1585     1585           
Flag Coverage Δ
#front 14.67% <100.00%> (+<0.01%) ⬆️
#unit 41.26% <ø> (ø)
Impacted Files Coverage Δ
...admin/src/containers/InstalledPluginsPage/index.js 7.14% <ø> (ø)
...kages/strapi-admin/admin/src/translations/index.js 100.00% <ø> (ø)
...-manager/admin/src/components/DynamicZone/index.js 0.00% <ø> (ø)
...in-content-manager/admin/src/translations/index.js 0.00% <ø> (ø)
...ntent-type-builder/admin/src/translations/index.js 0.00% <ø> (ø)
...ugin-documentation/admin/src/translations/index.js 0.00% <ø> (ø)
...trapi-plugin-email/admin/src/translations/index.js 0.00% <ø> (ø)
.../containers/InputModalStepper/InputModalStepper.js 0.00% <ø> (ø)
...-upload/admin/src/containers/ModalStepper/index.js 0.00% <ø> (ø)
...rapi-plugin-upload/admin/src/translations/index.js 0.00% <ø> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2243af...ef65cfd. Read the comment docs.

Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for taking the time to contribute to the project!

@soupette soupette added the source: core:admin Source is core/admin package label Jun 1, 2020
@soupette soupette added this to the 3.0.2 milestone Jun 1, 2020
@alexandrebodin alexandrebodin added the issue: enhancement Issue suggesting an enhancement to an existing feature label Jun 15, 2020
@alexandrebodin alexandrebodin merged commit d58a55d into strapi:master Jun 15, 2020
iicdii pushed a commit to iicdii/strapi that referenced this pull request Jul 2, 2020
…tent-manager' plugin (strapi#6439)

* fix: add Enable, Disable, and Done trad on email plugin

Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>

* fix: add translation for dinamic zone required component error

Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>

* fix: back to form.button.done, turns out other dont have form.button.done on strapi-admin

Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>

* feat: add replace media translation support

Signed-off-by: Fadhil Ahmad <fadzbobby95@gmail.com>
Signed-off-by: harimkims <harimkims@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants