Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing messages when uninstalling plugins #6463

Merged
merged 2 commits into from Jun 8, 2020
Merged

Fixing messages when uninstalling plugins #6463

merged 2 commits into from Jun 8, 2020

Conversation

thiagoaugusto
Copy link
Contributor

Description of what you did:

Fixing messages when uninstalling plugins #5490

Signed-off-by: Thiago Augusto <thiago.android88@gmail.com>
@codecov
Copy link

codecov bot commented May 30, 2020

Codecov Report

Merging #6463 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6463   +/-   ##
=======================================
  Coverage   19.85%   19.85%           
=======================================
  Files         857      857           
  Lines       12076    12076           
  Branches     1963     1963           
=======================================
  Hits         2398     2398           
  Misses       8093     8093           
  Partials     1585     1585           
Flag Coverage Δ
#front 14.66% <ø> (ø)
#unit 41.26% <ø> (ø)
Impacted Files Coverage Δ
...admin/src/containers/InstalledPluginsPage/index.js 7.14% <ø> (ø)
...ntent-type-builder/controllers/validation/types.js 52.27% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 664395a...5826629. Read the comment docs.

Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for taking the time to contribute to the project!

@soupette soupette added source: core:admin Source is core/admin package issue: enhancement Issue suggesting an enhancement to an existing feature labels Jun 1, 2020
@soupette soupette added this to the 3.0.2 milestone Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants