Fix cloudinary upload error message #6525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6525 +/- ##
==========================================
+ Coverage 19.85% 19.98% +0.13%
==========================================
Files 857 858 +1
Lines 12076 12097 +21
Branches 1963 1965 +2
==========================================
+ Hits 2398 2418 +20
- Misses 8093 8094 +1
Partials 1585 1585
Continue to review full report at Codecov.
|
|
Hi @sudhirt4, I don't think these errors should be sent back by the API. We should log them and send a upload error instead so we don't leak too many information |
|
@alexandrebodin |
| @@ -19,7 +19,8 @@ module.exports = { | |||
| { resource_type: 'auto', public_id: file.hash, ...customConfig }, | |||
| (err, image) => { | |||
| if (err) { | |||
| return reject(err); | |||
| console.log(`Error uploading to cloudinary: ${err.message}`); | |||
There was a problem hiding this comment.
here you will need to use strapi.log.error()
Signed-off-by: Sudhir Shrestha <sudhirshrestha@live.com>
alexandrebodin
approved these changes
Jun 24, 2020
alexandrebodin
added
source: core:upload
iicdii
pushed a commit
to iicdii/strapi
that referenced
this pull request
Jul 2, 2020
Signed-off-by: Sudhir Shrestha <sudhirshrestha@live.com> Signed-off-by: harimkims <harimkims@gmail.com>
gilfernandes
pushed a commit
to onepointconsulting/strapi
that referenced
this pull request
Aug 13, 2020
Signed-off-by: Sudhir Shrestha <sudhirshrestha@live.com> Signed-off-by: Gil Fernandes <gil.fernandes@onepointltd.com>
This was referenced Jun 6, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor pull request that fixes the propagation of error from cloudinary to strapi error middleware (err at : boom.Boomify).
Before (when entering invalid cloudinary config)
After