Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docker-compose examples #6566

Merged
merged 7 commits into from
Jul 29, 2020
Merged

Update docker-compose examples #6566

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7961a22
Change volume for strapi in SQLite for consistency
azrikahar Jun 5, 2020
c9c57ce
Remove "links" option for PostgreSQL & MongoDB
azrikahar Jun 5, 2020
2865525
Add "depends_on" option for PostgreSQL & MongoDB
azrikahar Jun 5, 2020
7b5088b
Changed volume for strapi in MongoDB example
azrikahar Jun 5, 2020
33a9427
Add database init name environment variables
azrikahar Jun 5, 2020
4967631
Remove exposed ports for databases
azrikahar Jun 5, 2020
1dcac52
Update docker.md
alexandrebodin Jul 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 8 additions & 10 deletions docs/v3.x/installation/docker.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ services:
strapi:
image: strapi/strapi
volumes:
- ./:/srv/app
- ./app:/srv/app
ports:
- '1337:1337'
```
Expand All @@ -42,22 +42,21 @@ services:
DATABASE_PORT: 5432
DATABASE_USERNAME: strapi
DATABASE_PASSWORD: strapi
links:
- postgres:postgres
volumes:
- ./app:/srv/app
ports:
- '1337:1337'
depends_on:
- postgres

postgres:
image: postgres
environment:
POSTGRES_DB: strapi
POSTGRES_USER: strapi
POSTGRES_PASSWORD: strapi
volumes:
- ./data:/var/lib/postgresql/data
ports:
- '5432:5432'
```

:::
Expand All @@ -76,22 +75,21 @@ services:
DATABASE_PORT: 27017
DATABASE_USERNAME: strapi
DATABASE_PASSWORD: strapi
links:
- mongo:mongo
volumes:
- ./app:/srv/app
ports:
- '1337:1337'
depends_on:
- mongo

mongo:
image: mongo
environment:
MONGO_INITDB_DATABASE: strapi
MONGO_INITDB_ROOT_USERNAME: strapi
MONGO_INITDB_ROOT_PASSWORD: strapi
volumes:
- ./data/db:/data/db
ports:
- '27017:27017'
- ./db:/data/db
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use ./data so it is consistent between every examples :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply. Thank you for taking your time to change it. 👍

```

:::
Expand Down