Fixed input checkbox behavior #6663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move click action to wrapper (parent) to allow clicks on whole area of checkbox. Also update the highlighting and visibility on hover of configuration wheel for better usability. This way the user learns that clicking on the item or wheel opens the configuration and clicking on the text or checkbox toggles the checkbox. Signed-off-by: Christos Malliaridis <c.malliaridis@gmail.com>
Move input selected state from controller to parent component (plugin) to prevent multiple selections and highlighting of checkbox fields from different controllers. Signed-off-by: Christos Malliaridis <c.malliaridis@gmail.com>
malliaridis
force-pushed
the
fix/input-checkbox-behavior
branch
from
339cb12
to
371a741
Compare
Codecov Report
@@ Coverage Diff @@
## master #6663 +/- ##
==========================================
+ Coverage 19.85% 19.98% +0.12%
==========================================
Files 857 858 +1
Lines 12076 12098 +22
Branches 1963 1965 +2
==========================================
+ Hits 2398 2418 +20
- Misses 8093 8095 +2
Partials 1585 1585
Continue to review full report at Codecov.
|
soupette
suggested changes
Jun 17, 2020
| @@ -14,9 +14,8 @@ import InputCheckbox from '../InputCheckboxPlugin'; | |||
|
|
|||
| import { Header, Label, Separator, Wrapper } from './Components'; | |||
|
|
|||
| function Controller({ actions, inputNamePath, isOpen, name }) { | |||
| function Controller({ actions, inputNamePath, isOpen, name, inputSelected, setInputSelected }) { | |||
There was a problem hiding this comment.
Can you remove the { useState } import since it is not needed anymore?
There was a problem hiding this comment.
Bad idea to skip once the linter.
Updated the branch and removed the import. :)
P.S. Sorry for the multiple force-pushes (if you got any notifications). I avoided auto formatting issues while commiting. If I should run any formatting to the rest of the code let me know.
malliaridis
force-pushed
the
fix/input-checkbox-behavior
branch
from
ec5d8f8
to
00b1c75
Compare
Signed-off-by: Christos Malliaridis <c.malliaridis@gmail.com>
malliaridis
force-pushed
the
fix/input-checkbox-behavior
branch
from
a1e23c3
to
d77ab73
Compare
soupette
added
the
source: plugin:users-permissions
This was referenced Jun 6, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what you did:
Updated the click behavior of the input checkbox field. Now the fields can be selected without
toggling the checkbox by clicking on the white surface or the config wheel. Toggling still possible
by clicking on the word or checkbox (like before).
Also moved the input selected state to the plugin (from controller) to prevent multiple selections
of input fields (with highlighting) from different controllers. This visibility bug occurred while
fixing the actual behavior of the input checkboxes.
Fix #5437