Fix init reset password permission #6696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim LAURIE <j.laurie6993@gmail.com>
lauriejim
added
issue: bug
iicdii
pushed a commit
to iicdii/strapi
that referenced
this pull request
Jul 2, 2020
Signed-off-by: Jim LAURIE <j.laurie6993@gmail.com> Signed-off-by: harimkims <harimkims@gmail.com>
nicksp
reviewed
Jul 10, 2020
| @@ -22,7 +22,7 @@ const DEFAULT_PERMISSIONS = [ | |||
| type: 'users-permissions', | |||
| roleType: 'public', | |||
| }, | |||
| { action: 'changepassword', controller: 'auth', type: 'users-permissions', roleType: 'public' }, | |||
| { action: 'resetPassword', controller: 'auth', type: 'users-permissions', roleType: 'public' }, | |||
There was a problem hiding this comment.
@alexandrebodin I know this is merged already, but this seems might not work as one might expect. The correct action name is resetpassword. 🤔 Or is it case insensitive?
I also noticed that bug mentioin in the ticket a while ago and what I did was setting this permission programmatically. And I used exactly a lowercased action name:
const permissionQuery = strapi.query('permission', 'users-permissions')
const params = {
role: ID,
type: 'users-permissions',
controller: 'auth',
action: 'resetpassword'
}
<..>
if (!existingPermission) {
await permissionQuery.create({
...params,
enabled: true
})
}This is also the name used in a DB:
This was referenced Jun 6, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what you did:
When the
changepasswordfunction has been renamedresetpassword.the init permissions hasn't been updated?
So the function has been no longer available by default for the public role.
close #6440