Fix broken link install plugin popup #6698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New link for documentation that pops up as overlay in Strapi. (plugin install blocker)
IamLizu
previously approved these changes
Jun 28, 2020
lauriejim
previously approved these changes
Jun 29, 2020
lauriejim
added
source: core:admin
derrickmehaffy
requested changes
Jul 9, 2020
| @@ -73,7 +73,7 @@ class OverlayBlocker extends React.Component { | |||
| <div className="buttonContainer"> | |||
| <a | |||
| className={cn('primary', 'btn')} | |||
| href="https://strapi.io/documentation/configurations/configurations.html#server" | |||
| href="https://strapi.io/documentation/v3.x/getting-started/introduction.html" | |||
There was a problem hiding this comment.
If we are just going to direct them to the documentation (and not the specific page) then we should just set the link to https://strapi.io/documentation which will prevent further issues if the path changes.
There was a problem hiding this comment.
@derrickmehaffy Damn. My mistake. Yah that would definitely prevent future issues. Updating the requested change.
Codecov Report
@@ Coverage Diff @@
## master #6698 +/- ##
==========================================
+ Coverage 19.86% 20.05% +0.18%
==========================================
Files 857 858 +1
Lines 12078 12049 -29
Branches 1963 1951 -12
==========================================
+ Hits 2399 2416 +17
+ Misses 8094 8062 -32
+ Partials 1585 1571 -14
Continue to review full report at Codecov.
|
derrickmehaffy
approved these changes
Jul 9, 2020
gilfernandes
pushed a commit
to onepointconsulting/strapi
that referenced
this pull request
Aug 13, 2020
* fixed broken link New link for documentation that pops up as overlay in Strapi. (plugin install blocker) * updated the requested change for fix broken link Signed-off-by: Gil Fernandes <gil.fernandes@onepointltd.com>
This was referenced Jun 6, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New link for the button Read the documentation that pops up as overlay in Strapi. (plugin install blocker)
Description of what you did:
Fixed read the doc button link. #6669
The button was broken with an old link. Replaced it with new link.