load dotenv lib at start #6701
Merged
load dotenv lib at start #6701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allows setting STRAPI_LOG_PRETTY_PRINT, STRAPI_LOG_LEVEL etc in env file Signed-off-by: Akash P <aksdevac@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #6701 +/- ##
==========================================
+ Coverage 19.86% 20.05% +0.19%
==========================================
Files 857 858 +1
Lines 12078 12050 -28
Branches 1963 1951 -12
==========================================
+ Hits 2399 2417 +18
+ Misses 8094 8062 -32
+ Partials 1585 1571 -14
Continue to review full report at Codecov.
|
alexandrebodin
requested changes
Jul 16, 2020
packages/strapi/lib/Strapi.js
Outdated
| @@ -1,6 +1,14 @@ | |||
| 'use strict'; | |||
|
|
|||
| // Dependencies. | |||
| const dotenv = require('dotenv'); | |||
|
|
|||
| if(process.env.ENV_PATH) { | |||
There was a problem hiding this comment.
You don't need to do the if statement here :)
alexandrebodin
added
source: core:strapi
Signed-off-by: Akash P <aksdevac@gmail.com>
gilfernandes
pushed a commit
to onepointconsulting/strapi
that referenced
this pull request
Aug 13, 2020
* load dotenv lib at start allows setting STRAPI_LOG_PRETTY_PRINT, STRAPI_LOG_LEVEL etc in env file Signed-off-by: Akash P <aksdevac@gmail.com> * remove extra if statement Signed-off-by: Akash P <aksdevac@gmail.com> Signed-off-by: Gil Fernandes <gil.fernandes@onepointltd.com>
This was referenced Jun 6, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows setting STRAPI_LOG_PRETTY_PRINT, STRAPI_LOG_LEVEL etc in env file
Description of what you did:
Load env vars from env file at starpi start, allows setting STRAPI_LOG_LEVEL, STRAPI_LOG_PRETTY_PRINT, STRAPI_LOG_TIMESTAMP etc related to #6693.
but it might not fix it as middleware config is overriding log level to 'debug', using default json file, not sure if I can use this env variable(STRAPI_LOG_LEVEL) in that logger middlerware's defaults json file, but it allows use of other vars like STRAPI_LOG_PRETTY_PRINT, STRAPI_LOG_TIMESTAMP & STRAPI_LOG_FORCE_COLOR