Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upload providers README to reflect stable changes #6709

Merged
merged 1 commit into from Jun 18, 2020

Conversation

derrickmehaffy
Copy link
Member

Signed-off-by: Derrick Mehaffy derrickmehaffy@gmail.com

Description of what you did:

Updated the README files of the 3 upload providers to use the ./config/plugins.js instead of extensions.

Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>
@derrickmehaffy derrickmehaffy added issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes labels Jun 17, 2020
@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #6709 into master will increase coverage by 0.13%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6709      +/-   ##
==========================================
+ Coverage   19.85%   19.98%   +0.13%     
==========================================
  Files         857      858       +1     
  Lines       12076    12097      +21     
  Branches     1963     1965       +2     
==========================================
+ Hits         2398     2418      +20     
- Misses       8093     8094       +1     
  Partials     1585     1585              
Flag Coverage Δ
#front 14.67% <50.00%> (+<0.01%) ⬆️
#unit 41.71% <95.00%> (+0.45%) ⬆️
Impacted Files Coverage Δ
...admin/src/containers/InstalledPluginsPage/index.js 7.14% <ø> (ø)
...kages/strapi-admin/admin/src/translations/index.js 100.00% <ø> (ø)
...-manager/admin/src/components/DynamicZone/index.js 0.00% <ø> (ø)
...in-content-manager/admin/src/translations/index.js 0.00% <ø> (ø)
...lder/admin/src/containers/FormModal/utils/forms.js 0.00% <0.00%> (ø)
...ntent-type-builder/admin/src/translations/index.js 0.00% <ø> (ø)
...ugin-documentation/admin/src/translations/index.js 0.00% <ø> (ø)
...trapi-plugin-email/admin/src/translations/index.js 0.00% <ø> (ø)
.../containers/InputModalStepper/InputModalStepper.js 0.00% <ø> (ø)
...-upload/admin/src/containers/ModalStepper/index.js 0.00% <ø> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6774667...2e5dc57. Read the comment docs.

Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin
Copy link
Member

@derrickmehaffy can you make this PR on the documentation branch so we can deploy it directly after merging

@derrickmehaffy
Copy link
Member Author

derrickmehaffy commented Jun 17, 2020

@alexandrebodin it doesn't directly change the docs, only the README.md files in the git so I think pushing it straight to master would be better as you won't need to merge in the doc branch.

I only set the doc tag as it's kinda doc related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants