Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6733 #6738

Merged
merged 1 commit into from Jun 19, 2020
Merged

Fixes #6733 #6738

merged 1 commit into from Jun 19, 2020

Conversation

soupette
Copy link
Contributor

Signed-off-by: soupette cyril.lpz@gmail.com

Description of what you did:

This PR fixes the removed import of React in the users-permissions plugin.

Fixes #6733

Signed-off-by: soupette <cyril.lpz@gmail.com>
@soupette soupette added the source: plugin:users-permissions Source is plugin/users-permissions package label Jun 19, 2020
@soupette soupette added this to the 3.0.4 milestone Jun 19, 2020
@soupette soupette added the issue: bug Issue reporting a bug label Jun 19, 2020
@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #6738 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6738   +/-   ##
=======================================
  Coverage   19.98%   19.99%           
=======================================
  Files         858      858           
  Lines       12098    12095    -3     
  Branches     1965     1965           
=======================================
  Hits         2418     2418           
+ Misses       8095     8092    -3     
  Partials     1585     1585           
Flag Coverage Δ
#front 14.67% <0.00%> (+<0.01%) ⬆️
#unit 41.71% <ø> (ø)
Impacted Files Coverage Δ
...trapi-admin/admin/src/containers/AuthPage/index.js 0.00% <0.00%> (ø)
...rapi-plugin-upload/admin/src/translations/index.js 0.00% <ø> (ø)
...rmissions/admin/src/components/Controller/index.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c909d71...08ad19b. Read the comment docs.

Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin alexandrebodin merged commit c28b703 into master Jun 19, 2020
@alexandrebodin alexandrebodin deleted the fix/#6733 branch June 19, 2020 07:17
@dngrhm
Copy link

dngrhm commented Jun 19, 2020

Thanks for the quick fix!! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: plugin:users-permissions Source is plugin/users-permissions package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open Roles in React is not defined
3 participants