New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added instructions for installing the pg
node module
#6744
Conversation
Signed-off-by: soupette <cyril.lpz@gmail.com>
I believe this is necessary to deploy to Google app engine - my deployment didn't work until I did this
Codecov Report
@@ Coverage Diff @@
## documentation #6744 +/- ##
=================================================
+ Coverage 19.14% 19.99% +0.85%
=================================================
Files 855 858 +3
Lines 11933 12095 +162
Branches 1898 1965 +67
=================================================
+ Hits 2284 2418 +134
+ Misses 8100 8092 -8
- Partials 1549 1585 +36
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and you are correct
Can you please change the branch from Master to Documentation though? See the following: https://github.com/strapi/strapi/blob/master/CONTRIBUTING.md#documentation |
Hey @spobwoode you changed your PR base branch but your PR now contains so commits it shouldn't. Do you mind updating it to only contain one commit :) |
This reverts commit 3da33ec.
@alexandrebodin - Sorry, in trying to clean up this PR I think I might have just made it messier :/ Can you tell me how I can fix this? As you might have guessed, I'm a bit of a n00b |
If you are not too familiar with git I would recommend you create a new branch and make a new PR :) Otherwise you definitely should read about git rebase ;) |
@spobwoode do you mind update your PR ? |
I believe this is necessary to deploy to Google app engine - my deployment didn't work until I did this
Description of what you did: