Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update migration-guide-beta.20-to-3.0.0.md #6750

Merged
merged 1 commit into from Jul 16, 2020
Merged

Update migration-guide-beta.20-to-3.0.0.md #6750

merged 1 commit into from Jul 16, 2020

Conversation

emahuni
Copy link
Contributor

@emahuni emahuni commented Jun 21, 2020

I did everything but noticed that the documentation isn't clear about hooks. I literally moved contents of the hook.json file to a new file hook.js without the settings key and nothing worked until I moved into settings key as specified in the hooks section.

Description of what you did:

edited migration guide to indicate correct hook.js migration

I did everything but noticed that the documentation isn't clear about hooks. I literally moved contents of the hook.json file to a new file hook.js without the settings key and nothing worked until I moved into settings key as specified in the hooks section.
@codecov
Copy link

codecov bot commented Jun 21, 2020

Codecov Report

Merging #6750 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6750   +/-   ##
=======================================
  Coverage   19.99%   19.99%           
=======================================
  Files         858      858           
  Lines       12095    12095           
  Branches     1965     1965           
=======================================
  Hits         2418     2418           
  Misses       8092     8092           
  Partials     1585     1585           
Flag Coverage Δ
#front 14.67% <ø> (ø)
#unit 41.71% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ed11a6...65b7df4. Read the comment docs.

Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement !

@alexandrebodin alexandrebodin added this to the 3.0.6 milestone Jul 16, 2020
@alexandrebodin alexandrebodin added source: docs Documentation changes issue: enhancement Issue suggesting an enhancement to an existing feature labels Jul 16, 2020
@alexandrebodin alexandrebodin merged commit 9a6de2a into strapi:master Jul 16, 2020
gilfernandes pushed a commit to onepointconsulting/strapi that referenced this pull request Aug 13, 2020
I did everything but noticed that the documentation isn't clear about hooks. I literally moved contents of the hook.json file to a new file hook.js without the settings key and nothing worked until I moved into settings key as specified in the hooks section.

Signed-off-by: Gil Fernandes <gil.fernandes@onepointltd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants