Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing images on index.html #6764

Merged
merged 1 commit into from Jun 24, 2020
Merged

fix missing images on index.html #6764

merged 1 commit into from Jun 24, 2020

Conversation

petersg83
Copy link
Contributor

Fix #6301
Fix #6454

Finishes work begun on #6637

Description of what you did:

  • created a koaStatic route for index.html images
  • added image to local instead of https://strapi.io/assets/images

@codecov
Copy link

codecov bot commented Jun 22, 2020 •
edited

Codecov Report

Merging #6764 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6764   +/-   ##
=======================================
  Coverage   19.99%   19.99%           
=======================================
  Files         858      858           
  Lines       12095    12095           
  Branches     1965     1965           
=======================================
  Hits         2418     2418           
  Misses       8092     8092           
  Partials     1585     1585
Flag Coverage Δ
#front 14.67% <ø> (ø)
#unit 41.71% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ed11a6...1a097ab. Read the comment docs.

@petersg83 petersg83 marked this pull request as draft June 22, 2020 17:27
@petersg83
fix missing images on index.html
1a097ab 
Signed-off-by: Pierre Noël <petersg83@gmail.com>
@petersg83 petersg83 marked this pull request as ready for review June 23, 2020 08:41
alexandrebodin
alexandrebodin approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin alexandrebodin added this to the 3.0.6 milestone Jun 24, 2020
@alexandrebodin alexandrebodin added source: core:strapi Source is core/strapi package issue: bug Issue reporting a bug labels Jun 24, 2020
@alexandrebodin alexandrebodin merged commit b2aa657 into master Jun 24, 2020
@alexandrebodin alexandrebodin mentioned this pull request Jun 24, 2020
Closed
@alexandrebodin alexandrebodin deleted the fix/imagesMissing branch June 24, 2020 07:58
This was referenced Jun 6, 2021
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrebodin alexandrebodin alexandrebodin approved these changes

@Convly Convly Awaiting requested review from Convly

Assignees
No one assigned
Labels
issue: bug Issue reporting a bug source: core:strapi Source is core/strapi package
Projects
None yet
Milestone
3.0.6
Development

Successfully merging this pull request may close these issues.

The image keeps on crashing in the site logo_login.jpg points to strapi.io not local asset
2 participants
@petersg83 @alexandrebodin