Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typofix] Client ID > Client Secret #6786

Merged
merged 2 commits into from Jun 24, 2020

Conversation

ScottAgirs
Copy link
Contributor

Signed-off-by: ScottAgirs scott@ijs.to

Description of what you did:

Signed-off-by: ScottAgirs <scott@ijs.to>
@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #6786 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6786   +/-   ##
=======================================
  Coverage   19.99%   19.99%           
=======================================
  Files         858      858           
  Lines       12095    12095           
  Branches     1965     1965           
=======================================
  Hits         2418     2418           
  Misses       8092     8092           
  Partials     1585     1585           
Flag Coverage Δ
#front 14.67% <ø> (ø)
#unit 41.71% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaf40e1...3d9c73d. Read the comment docs.

Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add arrowParens option into prettier rc and set it to avoid.

Signed-off-by: ScottAgirs <scott@ijs.to>
@ScottAgirs
Copy link
Contributor Author

Can you please add arrowParens option into prettier rc and set it to avoid.

done w 3d9c73d

Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for the fix !

@alexandrebodin alexandrebodin added this to the 3.0.6 milestone Jun 24, 2020
@alexandrebodin alexandrebodin added source: docs Documentation changes issue: enhancement Issue suggesting an enhancement to an existing feature labels Jun 24, 2020
@alexandrebodin alexandrebodin merged commit fef24fa into strapi:master Jun 24, 2020
iicdii pushed a commit to iicdii/strapi that referenced this pull request Jul 2, 2020
* [typofix] Client ID > Client Secret

Signed-off-by: ScottAgirs <scott@ijs.to>

* [revert] avoid arrowParens

Signed-off-by: ScottAgirs <scott@ijs.to>
Signed-off-by: harimkims <harimkims@gmail.com>
gilfernandes pushed a commit to onepointconsulting/strapi that referenced this pull request Aug 13, 2020
* [typofix] Client ID > Client Secret

Signed-off-by: ScottAgirs <scott@ijs.to>

* [revert] avoid arrowParens

Signed-off-by: ScottAgirs <scott@ijs.to>
Signed-off-by: Gil Fernandes <gil.fernandes@onepointltd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants