Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve migration guide to beta.20 #6793

Merged
merged 2 commits into from Jul 9, 2020

Conversation

iicdii
Copy link
Contributor

@iicdii iicdii commented Jun 24, 2020

Description of what you did:

I added logic to change file name to migration script, and add additional description of file name.

@iicdii iicdii force-pushed the docs/update-migration-beta.20 branch from 0bea7f1 to c28fd0d Compare June 24, 2020 08:09
@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #6793 into master will increase coverage by 0.13%.
The diff coverage is 91.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6793      +/-   ##
==========================================
+ Coverage   19.85%   19.99%   +0.13%     
==========================================
  Files         857      858       +1     
  Lines       12076    12095      +19     
  Branches     1963     1965       +2     
==========================================
+ Hits         2398     2418      +20     
+ Misses       8093     8092       -1     
  Partials     1585     1585              
Flag Coverage Δ
#front 14.67% <50.00%> (+0.01%) ⬆️
#unit 41.71% <95.23%> (+0.45%) ⬆️
Impacted Files Coverage Δ
...admin/src/containers/InstalledPluginsPage/index.js 7.14% <ø> (ø)
...kages/strapi-admin/admin/src/translations/index.js 100.00% <ø> (ø)
...-manager/admin/src/components/DynamicZone/index.js 0.00% <ø> (ø)
...in-content-manager/admin/src/translations/index.js 0.00% <ø> (ø)
...lder/admin/src/containers/FormModal/utils/forms.js 0.00% <0.00%> (ø)
...ntent-type-builder/admin/src/translations/index.js 0.00% <ø> (ø)
...ntent-type-builder/controllers/validation/types.js 52.27% <ø> (ø)
...ugin-documentation/admin/src/translations/index.js 0.00% <ø> (ø)
...trapi-plugin-email/admin/src/translations/index.js 0.00% <ø> (ø)
.../containers/InputModalStepper/InputModalStepper.js 0.00% <ø> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d01c10...c28fd0d. Read the comment docs.

@lauriejim
Copy link
Contributor

Waiting for the tech team approbation before merging it.

@@ -208,6 +217,9 @@ var models = {

Finally you can load this script in your mongo shell and run it.

Note that after migration the `name` field of the files you uploaded will be replaced with a name without an extension.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was reverted recently to leave the extension of the original file in the name by default.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this PR is still necessary

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexandrebodin Ok I just found #5971 extension is back to filename. But still, this can be a breaking change for some people(includes me, my frontend was broken with this change) until the new release comes out. So I think this PR is still necessary, and I think it's also necessary to let people know more about the changes when release come out. I know you Strapi team is very busy, but I want you to consider why people think that the absence of a "better document" is the most pain point. (#6634 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants