New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve migration guide to beta.20 #6793
Improve migration guide to beta.20 #6793
Conversation
…cription of file name Signed-off-by: harimkims <harimkims@gmail.com>
0bea7f1
to
c28fd0d
Compare
Codecov Report
@@ Coverage Diff @@
## master #6793 +/- ##
==========================================
+ Coverage 19.85% 19.99% +0.13%
==========================================
Files 857 858 +1
Lines 12076 12095 +19
Branches 1963 1965 +2
==========================================
+ Hits 2398 2418 +20
+ Misses 8093 8092 -1
Partials 1585 1585
Continue to review full report at Codecov.
|
Waiting for the tech team approbation before merging it. |
@@ -208,6 +217,9 @@ var models = { | |||
|
|||
Finally you can load this script in your mongo shell and run it. | |||
|
|||
Note that after migration the `name` field of the files you uploaded will be replaced with a name without an extension. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was reverted recently to leave the extension of the original file in the name by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this PR is still necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexandrebodin Ok I just found #5971 extension is back to filename. But still, this can be a breaking change for some people(includes me, my frontend was broken with this change) until the new release comes out. So I think this PR is still necessary, and I think it's also necessary to let people know more about the changes when release come out. I know you Strapi team is very busy, but I want you to consider why people think that the absence of a "better document" is the most pain point. (#6634 (comment))
…cription of file name (strapi#6793) Signed-off-by: harimkims <harimkims@gmail.com> Signed-off-by: Gil Fernandes <gil.fernandes@onepointltd.com>
Description of what you did:
I added logic to change file name to migration script, and add additional description of file name.