Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs review #6848

Merged
merged 8 commits into from Jul 28, 2020
Merged

Docs review #6848

merged 8 commits into from Jul 28, 2020

Conversation

lauriejim
Copy link
Contributor

Description of what you did:

Here is a global review of the docs. But as you know many thing should still be improved.
Part of my obj and after this review, I know items we have to improved.
Waiting also for our tech writer to help me on that point.

Signed-off-by: Jim LAURIE <j.laurie6993@gmail.com>
Signed-off-by: Jim LAURIE <j.laurie6993@gmail.com>
Signed-off-by: Jim LAURIE <j.laurie6993@gmail.com>
Signed-off-by: Jim LAURIE <j.laurie6993@gmail.com>
Signed-off-by: Jim LAURIE <j.laurie6993@gmail.com>
@lauriejim lauriejim added issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes labels Jun 29, 2020
Copy link
Member

@derrickmehaffy derrickmehaffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will dig a bit deeper but just a quick look through

docs/v3.x/getting-started/installation.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

Merging #6848 into documentation will increase coverage by 0.85%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           documentation    #6848      +/-   ##
=================================================
+ Coverage          19.14%   19.99%   +0.85%     
=================================================
  Files                855      858       +3     
  Lines              11933    12095     +162     
  Branches            1898     1965      +67     
=================================================
+ Hits                2284     2418     +134     
+ Misses              8100     8092       -8     
- Partials            1549     1585      +36     
Flag Coverage Δ
#front 14.67% <ø> (+0.18%) ⬆️
#unit 41.71% <ø> (+1.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/strapi-plugin-email/admin/src/pluginId.js 0.00% <0.00%> (-100.00%) ⬇️
...n/src/containers/NotificationProvider/constants.js 0.00% <0.00%> (-100.00%) ⬇️
...n/admin/src/containers/LanguageProvider/reducer.js 0.00% <0.00%> (-61.54%) ⬇️
packages/strapi-utils/lib/stringFormatting.js 50.00% <0.00%> (-50.00%) ⬇️
packages/strapi-plugin-graphql/services/utils.js 24.69% <0.00%> (-11.03%) ⬇️
...min/src/containers/NotificationProvider/reducer.js 0.00% <0.00%> (-10.00%) ⬇️
.../admin/src/components/LeftMenuLink/LeftMenuIcon.js 50.00% <0.00%> (-7.15%) ⬇️
...strapi-plugin-upload/config/functions/bootstrap.js 62.06% <0.00%> (-6.69%) ⬇️
...api-admin/admin/src/components/PluginCard/index.js 4.87% <0.00%> (-2.27%) ⬇️
...trapi-admin/admin/src/containers/HomePage/hooks.js 5.00% <0.00%> (-0.89%) ⬇️
... and 161 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 528dc41...771a2f7. Read the comment docs.

docs/v3.x/getting-started/installation.md Outdated Show resolved Hide resolved
docs/v3.x/plugins/upload.md Outdated Show resolved Hide resolved
lauriejim and others added 2 commits July 28, 2020 10:33
Signed-off-by: Jim LAURIE <j.laurie6993@gmail.com>
```

<<<<<<< HEAD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git conflict

Signed-off-by: Jim LAURIE <j.laurie6993@gmail.com>
@alexandrebodin alexandrebodin added this to the 3.1.2 milestone Jul 28, 2020
@alexandrebodin alexandrebodin merged commit 4c4a4c1 into documentation Jul 28, 2020
@alexandrebodin alexandrebodin deleted the docs-review branch July 28, 2020 08:48
gilfernandes pushed a commit to onepointconsulting/strapi that referenced this pull request Aug 13, 2020
* docs: improve getting started

Signed-off-by: Jim LAURIE <j.laurie6993@gmail.com>

* docs: review quickstart video and some steps

Signed-off-by: Jim LAURIE <j.laurie6993@gmail.com>

* docs: review concepts

Signed-off-by: Jim LAURIE <j.laurie6993@gmail.com>

* docs: review email - upload plugins

Signed-off-by: Jim LAURIE <j.laurie6993@gmail.com>

* fix: PR feedback

Signed-off-by: Jim LAURIE <j.laurie6993@gmail.com>

* fix: PR feedback type conflict

Signed-off-by: Jim LAURIE <j.laurie6993@gmail.com>
Signed-off-by: Gil Fernandes <gil.fernandes@onepointltd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants