Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting enhancements and Fixes #6858

Merged
merged 4 commits into from Aug 12, 2020
Merged

Formatting enhancements and Fixes #6858

merged 4 commits into from Aug 12, 2020

Conversation

kuldipem
Copy link
Contributor

Description of what you did:

@kuldipem
Fix: formatting
bb79011 
Signed-off-by: KULDIP PIPALIYA <kuldipem@gmail.com>
@kuldipem
Fix: formatting
008bb56 
Signed-off-by: KULDIP PIPALIYA <kuldipem@gmail.com>
@kuldipem
Enhance: consistance formatting for NOTE
78c5ad5 
Signed-off-by: KULDIP PIPALIYA <kuldipem@gmail.com>
@kuldipem
Enhance: consistance formatting for NOTE
65ba73e 
Signed-off-by: KULDIP PIPALIYA <kuldipem@gmail.com>
@codecov
Copy link

codecov bot commented Jun 30, 2020 •
edited

Codecov Report

Merging #6858 into documentation will increase coverage by 0.84%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           documentation    #6858      +/-   ##
=================================================
+ Coverage          19.14%   19.98%   +0.84%     
=================================================
  Files                855      858       +3     
  Lines              11933    12097     +164     
  Branches            1898     1965      +67     
=================================================
+ Hits                2284     2418     +134     
+ Misses              8100     8094       -6     
- Partials            1549     1585      +36
Flag Coverage Δ
#front 14.67% <ø> (+0.18%) ⬆️
#unit 41.71% <ø> (+1.77%) ⬆️
Impacted Files Coverage Δ
packages/strapi-plugin-email/admin/src/pluginId.js 0.00% <0.00%> (-100.00%) ⬇️
...n/src/containers/NotificationProvider/constants.js 0.00% <0.00%> (-100.00%) ⬇️
...n/admin/src/containers/LanguageProvider/reducer.js 0.00% <0.00%> (-61.54%) ⬇️
packages/strapi-utils/lib/stringFormatting.js 50.00% <0.00%> (-50.00%) ⬇️
packages/strapi-plugin-graphql/services/utils.js 24.69% <0.00%> (-11.03%) ⬇️
...min/src/containers/NotificationProvider/reducer.js 0.00% <0.00%> (-10.00%) ⬇️
.../admin/src/components/LeftMenuLink/LeftMenuIcon.js 50.00% <0.00%> (-7.15%) ⬇️
...strapi-plugin-upload/config/functions/bootstrap.js 62.06% <0.00%> (-6.69%) ⬇️
...api-admin/admin/src/components/PluginCard/index.js 4.87% <0.00%> (-2.27%) ⬇️
...trapi-admin/admin/src/containers/HomePage/hooks.js 5.00% <0.00%> (-0.89%) ⬇️
... and 160 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d707794...65ba73e. Read the comment docs.

@alexandrebodin alexandrebodin added source: docs Documentation changes issue: enhancement Issue suggesting an enhancement to an existing feature labels Jul 16, 2020
derrickmehaffy
derrickmehaffy approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@derrickmehaffy derrickmehaffy left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (After taking into account Jim's requirements)

@alexandrebodin alexandrebodin added this to the 3.1.4 milestone Aug 12, 2020
@alexandrebodin alexandrebodin merged commit fa8dfcc into strapi:documentation Aug 12, 2020
@kuldipem kuldipem deleted the documentation branch August 12, 2020 11:46
gilfernandes pushed a commit to onepointconsulting/strapi that referenced this pull request Aug 13, 2020
@kuldipem @onepointconsulting
Formatting enhancements and Fixes (strapi#6858)
1cc5c6e 
* Fix: formatting

Signed-off-by: KULDIP PIPALIYA <kuldipem@gmail.com>

* Fix: formatting

Signed-off-by: KULDIP PIPALIYA <kuldipem@gmail.com>

* Enhance: consistance formatting for NOTE

Signed-off-by: KULDIP PIPALIYA <kuldipem@gmail.com>

* Enhance: consistance formatting for NOTE

Signed-off-by: KULDIP PIPALIYA <kuldipem@gmail.com>
Signed-off-by: Gil Fernandes <gil.fernandes@onepointltd.com>
This was referenced Jun 6, 2021
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauriejim lauriejim lauriejim requested changes

@derrickmehaffy derrickmehaffy derrickmehaffy approved these changes

Assignees
No one assigned
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes
Projects
None yet
Milestone
3.1.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kuldipem @lauriejim @derrickmehaffy @alexandrebodin