Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add filtering to search route #6865

Merged
merged 3 commits into from Jul 1, 2020
Merged

add filtering to search route #6865

merged 3 commits into from Jul 1, 2020

Conversation

petersg83
Copy link
Contributor

Finish work started in this PR : #5534

@petersg83
add filtering to search route
950a214 
Signed-off-by: Pierre Noël <petersg83@gmail.com>
@petersg83
fix search for numbers for mongoDB < 4.2.0
25bfb72 
Signed-off-by: Pierre Noël <petersg83@gmail.com>
@codecov
Copy link

codecov bot commented Jun 30, 2020 •
edited

Codecov Report

Merging #6865 into master will increase coverage by 0.05%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6865      +/-   ##
==========================================
+ Coverage   19.99%   20.05%   +0.05%     
==========================================
  Files         858      858              
  Lines       12095    12049      -46     
  Branches     1965     1950      -15     
==========================================
- Hits         2418     2416       -2     
+ Misses       8092     8063      -29     
+ Partials     1585     1570      -15
Flag Coverage Δ
#front 14.67% <ø> (ø)
#unit 42.45% <42.85%> (+0.73%) ⬆️
Impacted Files Coverage Δ
packages/strapi-utils/lib/buildQuery.js 22.22% <0.00%> (+0.48%) ⬆️
packages/strapi-utils/lib/models.js 25.15% <ø> (+4.96%) ⬆️
packages/strapi-plugin-upload/services/Upload.js 17.03% <100.00%> (-0.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 535fa25...10092f5. Read the comment docs.

alexandrebodin
alexandrebodin requested changes Jun 30, 2020
View reviewed changes
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great !

packages/strapi-connector-mongoose/lib/buildQuery.js Outdated Show resolved Hide resolved
packages/strapi-connector-bookshelf/lib/queries.js Outdated Show resolved Hide resolved
packages/strapi-connector-mongoose/lib/queries.js Outdated Show resolved Hide resolved
@petersg83 petersg83 force-pushed the feature/addFiltersToSearch branch 2 times, most recently from ad4e94a to 5530df2 Compare July 1, 2020 09:56
@petersg83
refacto
10092f5 
Signed-off-by: Pierre Noël <petersg83@gmail.com>
@alexandrebodin alexandrebodin added this to the 3.0.6 milestone Jul 1, 2020
@alexandrebodin alexandrebodin added source: core:database Source is core/database package issue: enhancement Issue suggesting an enhancement to an existing feature labels Jul 1, 2020
alexandrebodin
alexandrebodin approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 💯 And Thank you @JelmerV-WFC for starting this !

@alexandrebodin alexandrebodin merged commit 8edb6cd into master Jul 1, 2020
@alexandrebodin alexandrebodin deleted the feature/addFiltersToSearch branch July 1, 2020 10:37
@derrickmehaffy derrickmehaffy mentioned this pull request Jul 13, 2020
Closed
This was referenced Jun 6, 2021
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrebodin alexandrebodin Awaiting requested review from alexandrebodin

Assignees
No one assigned
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:database Source is core/database package
Projects
None yet
Milestone
3.0.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@petersg83 @alexandrebodin