Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve russian translations #6903

Merged
merged 2 commits into from Sep 8, 2020
Merged

improve russian translations #6903

merged 2 commits into from Sep 8, 2020

Conversation

Ashot-KR
Copy link

@Ashot-KR Ashot-KR commented Jul 3, 2020

Improves some russian translations for admin UI:
fix some wrong translations
make some translations more "native"
add absent translations

Signed-off-by: Poluektov Dmitriy <dmitry.a@kr.digital>
@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #6903 into master will decrease coverage by 7.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6903      +/-   ##
==========================================
- Coverage   27.16%   20.05%   -7.12%     
==========================================
  Files        1163      858     -305     
  Lines       15518    12049    -3469     
  Branches     2410     1950     -460     
==========================================
- Hits         4216     2416    -1800     
+ Misses       9534     8063    -1471     
+ Partials     1768     1570     -198     
Flag Coverage Δ
#front 14.67% <ø> (-4.65%) ⬇️
#unit 42.45% <ø> (-11.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t-manager/admin/src/containers/EditView/reducer.js 0.00% <0.00%> (-100.00%) ⬇️
...manager/admin/src/containers/ListView/constants.js 0.00% <0.00%> (-100.00%) ⬇️
packages/strapi-utils/lib/sanitize-entity.js 5.55% <0.00%> (-94.45%) ⬇️
...t-manager/admin/src/containers/ListView/reducer.js 0.00% <0.00%> (-93.34%) ⬇️
...t-manager/admin/src/containers/ListView/actions.js 0.00% <0.00%> (-90.91%) ⬇️
...api-admin/admin/src/containers/AuthPage/reducer.js 0.00% <0.00%> (-85.72%) ⬇️
packages/strapi-utils/lib/config.js 13.51% <0.00%> (-51.36%) ⬇️
...strapi-admin/admin/src/containers/Admin/actions.js 50.00% <0.00%> (-50.00%) ⬇️
...strapi-admin/admin/src/containers/Admin/reducer.js 80.00% <0.00%> (-20.00%) ⬇️
packages/strapi-utils/lib/validators.js 88.88% <0.00%> (-6.95%) ⬇️
... and 661 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd29fe7...64ce27e. Read the comment docs.

@Ashot-KR Ashot-KR changed the title improve ru locale improve russian translations Jul 6, 2020
reslear
reslear previously approved these changes Jul 26, 2020
@alexandrebodin alexandrebodin added this to the 3.1.5 milestone Sep 4, 2020
@alexandrebodin alexandrebodin added source: core:admin Source is core/admin package type: translation labels Sep 4, 2020
@alexandrebodin
Copy link
Member

Hi @Ashot-KR Would you mind fixing the conflicts ;)

@alexandrebodin alexandrebodin removed this from the 3.1.5 milestone Sep 4, 2020
@Ashot-KR
Copy link
Author

Ashot-KR commented Sep 4, 2020

@alexandrebodin sure, i'll do it later today

@reslear
Copy link

reslear commented Sep 4, 2020

@Ashot-KR @alexandrebodin also look please another Russian language problem #7098 (Russian cyrillic ERROR on save - Content Type) Russian users really need. thx!

@Ashot-KR
Copy link
Author

Ashot-KR commented Sep 4, 2020

@reslear i got this error once 😄 actually pluralization in Russian not very easy thing. I will take a look and probably suggest some potential solutions

@Ashot-KR
Copy link
Author

Ashot-KR commented Sep 5, 2020

@alexandrebodin conflict resolved

Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants