Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mount-models.js to check if dynamic zone field exists from returned mongo object #6916

Merged
merged 1 commit into from Jul 6, 2020

Conversation

atlmtw
Copy link
Contributor

@atlmtw atlmtw commented Jul 5, 2020

This is to ensure custom mongoose queries that exclude dynamic zone fields don't fail.

Fix issue: #6016

Simple check to see if a dynamic field zone exists on returned mongo object.

This is to ensure custom mongoose queries that exclude dynamic zone fields don't fail.

Referring to this issue:
#6016
@atlmtw atlmtw changed the title Update mount-models.js to check ag Update mount-models.js to check if dynamic zone field exists from returned mongo object Jul 5, 2020
@codecov
Copy link

codecov bot commented Jul 5, 2020

Codecov Report

Merging #6916 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6916   +/-   ##
=======================================
  Coverage   20.05%   20.05%           
=======================================
  Files         858      858           
  Lines       12049    12049           
  Branches     1950     1950           
=======================================
  Hits         2416     2416           
  Misses       8063     8063           
  Partials     1570     1570           
Flag Coverage Δ
#front 14.67% <ø> (ø)
#unit 42.45% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd3c769...c35a59d. Read the comment docs.

Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for the fix !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:database Source is core/database package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants