Improve empty state grammar for Assets #6922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendo
force-pushed
the
fix_empty-state-grammar
branch
2 times, most recently
from
5a311a2
to
4508a7c
Compare
Codecov Report
@@ Coverage Diff @@
## master #6922 +/- ##
=======================================
Coverage 26.22% 26.22%
=======================================
Files 1131 1131
Lines 15433 15433
Branches 2443 2443
=======================================
Hits 4048 4048
Misses 9565 9565
Partials 1820 1820
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
@maevalienard can you check if the wording is ok for you? |
brendo
force-pushed
the
fix_empty-state-grammar
branch
from
17177fd
to
3bfecc5
Compare
soupette
previously approved these changes
Jul 29, 2020
soupette
added
source: core:upload
Signed-off-by: Brendan Abbott <brendan.abbott@shopify.com>
brendo
force-pushed
the
fix_empty-state-grammar
branch
from
3bfecc5
to
de36841
Compare
gilfernandes
pushed a commit
to onepointconsulting/strapi
that referenced
this pull request
Aug 13, 2020
Signed-off-by: Brendan Abbott <brendan.abbott@shopify.com> Signed-off-by: Gil Fernandes <gil.fernandes@onepointltd.com>
This was referenced Jun 6, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what you did:
This PR is a small tweak to the English translations to improve the empty state for the Media Library plugin.
Before
After