Fix invalid local uploads path

[akcyp]

File upload provider does not consider the strapi configuration. This patch should fix the problem.

Description of what you did:

// app.js
const path = require('path');
const strapiDir = path.join(__dirname, './backend');

const Strapi = require(path.join(strapiDir, `/node_modules/strapi`));
const strapi = Strapi({
  dir: strapiDir
});
strapi.start();

This configuration generates the following error when uploading the image:

ENOENT: no such file or directory, open 'C:\Users\XYZ\Desktop\backend\public\uploads\screenshot_862571e640.jpeg'

The correct directory should be:

C:\Users\XYZ\Desktop\app\backend\public\uploads\screenshot_862571e640.jpeg

[derrickmehaffy]

This will need to be checked against Mac and Linux

[alexandrebodin]

this doesn't need to be a function. you can use

const uploadDir = path.join(strapi.dir, strapi.config.middleware.settings.public.path || strapi.config.paths.static)

[alexandrebodin]

LGTM, Thank you 💯

[alexandrebodin]

I couldn't push to the fork you made for some reason...

You will need to fix the tests in packages/strapi-plugin-upload/test/tests/bootstrap.test.js

set the globa.strapi like so:

global.strapi = {
      dir: process.cwd(),
      admin: {
        services: { permission: { actionProvider: { register } } },
      },
      log: {
        error() {},
      },
      config: {
        get() {
          return 'public';
        },
        paths: {},
        info: {
          dependencies: {},
        },
      },
      plugins: {
        upload: {
          config: {
            provider: 'local',
          },
        },
      },
      store() {
        return {
          get() {
            return null;
          },
          set: setStore,
        };
      },
    };

Please also use strapi.config.get('middleware.settings.public.path', strapi.config.paths.static) to get the path :)

[akcyp]

You mean packages/strapi-plugin-upload/test/__tests__/bootstrap.test.js ? 😄
I made changes but when running jest ./packages/strapi-plugin-upload/test/__tests__/bootstrap.test.js tests failed 😢
The error ReferenceError: register is not defined occurs at line

services: { permission: { actionProvider: { register } } },

[codecov]

Codecov Report

Merging #6925 into master will decrease coverage by 7.89%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6925      +/-   ##
==========================================
- Coverage   26.17%   18.28%   -7.90%     
==========================================
  Files        1130     1021     -109     
  Lines       15406    11895    -3511     
  Branches     2436     1704     -732     
==========================================
- Hits         4033     2175    -1858     
+ Misses       9557     8266    -1291     
+ Partials     1816     1454     -362     

Flag	Coverage Δ
#front	18.28% <ø> (+<0.01%)	⬆️
#unit	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...permissions/admin/src/components/EditForm/index.js	0.00% <0.00%> (ø)
...ainers/EditViewDataManagerProvider/utils/schema.js	0.00% <0.00%> (ø)
...t-type-builder/controllers/validation/constants.js
packages/strapi-utils/lib/sanitize-entity.js
packages/strapi-admin/domain/user.js
packages/strapi-admin/domain/condition.js
...strapi/lib/services/entity-validator/validators.js
packages/strapi-admin/services/auth.js
...manager/services/utils/configuration/attributes.js
...ackages/strapi/lib/load/check-reserved-filename.js
... and 100 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3363415...a16202c. Read the comment docs.

[alexandrebodin]

@akcyp You need to update your branch (merge master) and then follow the previous comment ;)

[akcyp]

Thanks and forgive me for making corrections now, but I was on vacation. I hope everything will be ok now! 💯 😄

[alexandrebodin]

LGTM !

[moritz-halke]

Hi, with 3.0.* we had configured paths.static to use a absolute path (e.g. /mnt/storage/uploads) instead of the default ./uploads location. With this change the strapi.dir always prepends the pwd() location, thus screwing with our config.

As a workaround, cloned the local provider (making a custom provider) and removed the strapi.dir prefix. But I'm not sure if this is the best approach.

Is there a better way to configure an absolute path for the upload folder?

[alexandrebodin]

@moritz-halke a fix is ready for the next release: #7280