Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong flag for Swedish #6926

Merged
merged 2 commits into from Jul 15, 2020
Merged

Conversation

vincentdoerig
Copy link
Contributor

Description of what you did:

Fixes #6912 — Add another case for Swedish since the language code (sv) is different than the country code (se).

Signed-off-by: Vincent Dörig <dvincdt@gmail.com>
Signed-off-by: Vincent Dörig <dvincdt@gmail.com>
@@ -117,6 +117,15 @@ describe('<LocaleToggle />', () => {
);
});

it('should return the se flag', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return the sv flag ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sv would be El Salvador, se is Sweden

Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin alexandrebodin added this to the 3.0.6 milestone Jul 15, 2020
@alexandrebodin alexandrebodin added source: core:admin Source is core/admin package issue: bug Issue reporting a bug labels Jul 15, 2020
@alexandrebodin alexandrebodin merged commit c587bda into strapi:master Jul 15, 2020
@vincentdoerig vincentdoerig deleted the fix/sweden-flag branch July 15, 2020 16:34
gilfernandes pushed a commit to onepointconsulting/strapi that referenced this pull request Aug 13, 2020
* Fix wrong flag for Swedish language

Signed-off-by: Vincent Dörig <dvincdt@gmail.com>

* Add test case

Signed-off-by: Vincent Dörig <dvincdt@gmail.com>
Signed-off-by: Gil Fernandes <gil.fernandes@onepointltd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong flag is shown for swedish language.
2 participants