Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes misleading documentation #6927

Merged
merged 1 commit into from Jul 15, 2020
Merged

Conversation

nunsie
Copy link
Contributor

@nunsie nunsie commented Jul 7, 2020

Description of what you did:

removes misleading documentation around which fields on the USER model can be used in the email templates, as at this commit: ccb428e#diff-bbc9dda26221803c32574c89c58bdb24R6

only email and username may be referenced in the email template

removes misleading documentation around which fields on the USER model can be used in the email templates
@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #6927 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6927   +/-   ##
=======================================
  Coverage   20.05%   20.05%           
=======================================
  Files         858      858           
  Lines       12049    12049           
  Branches     1951     1951           
=======================================
  Hits         2416     2416           
  Misses       8062     8062           
  Partials     1571     1571           
Flag Coverage Δ
#front 14.67% <ø> (ø)
#unit 42.45% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b03cb74...558d79e. Read the comment docs.

Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks !

@alexandrebodin alexandrebodin added this to the 3.0.6 milestone Jul 15, 2020
@alexandrebodin alexandrebodin added source: docs Documentation changes issue: enhancement Issue suggesting an enhancement to an existing feature labels Jul 15, 2020
@alexandrebodin alexandrebodin merged commit f496970 into strapi:master Jul 15, 2020
gilfernandes pushed a commit to onepointconsulting/strapi that referenced this pull request Aug 13, 2020
removes misleading documentation around which fields on the USER model can be used in the email templates

Signed-off-by: Gil Fernandes <gil.fernandes@onepointltd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants