New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: image URL in README.md #6988
Conversation
updated logo image URL
Codecov Report
@@ Coverage Diff @@
## master #6988 +/- ##
==========================================
- Coverage 26.18% 20.05% -6.13%
==========================================
Files 1130 858 -272
Lines 15404 12050 -3354
Branches 2435 1951 -484
==========================================
- Hits 4033 2417 -1616
+ Misses 9556 8062 -1494
+ Partials 1815 1571 -244
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Thanks @iamdarshshah, closing as the image is already up to date |
Hello @alexandrebodin It looks like, the issue still exists. Can you please have a look at it again? |
Hum looks good on my side... The image is hosted on GitHub so that's weird. |
@lauriejim It seems the issue is common across the different browsers. It could not be related to Cache. Maybe something else. Can you please share the screenshot? Thanks 👍 |
Okay, cool! No problem... If it works fine then there is no need for updating it. Still don't know why it's not working for me 😕 Will try to look for the solution to this issue. Anyways! Thank you 👍 |
Let us know if this comes from a specific browser so we can fix it :D |
@alexandrebodin
Screenshots:
|
This might happen due to the fact that Amazon AWS serves content to specific locations or rather I would say, It will work for certain locations only. It restricts data access to certain locations, this seems to be the reason for this issue. Due to which I can't access this particular file. Also, tried visiting current image URL directly and got this error as a response: We can update the URL by would appreciate your thoughts/ideas on this @lauriejim & @alexandrebodin |
@iamdarshshah You can actually use this one instead so it is the right one :D https://strapi.io/assets/strapi-logo-dark.svg |
@alexandrebodin Sure, Updating that! But, need to reopen this PR to update the commit. Thanks 👍 |
@alexandrebodin Should I open new PR for updating image URL? |
@iamdarshshah I'll reopen this one so you can update 👍 |
Thanks @alexandrebodin 👍 , I have updated the image URL. You can review it now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM THanks !
* Update README.md updated logo image URL * Updated link * fix: image url Signed-off-by: Tomaszal <mrtomaszal@gmail.com>
* Update README.md updated logo image URL * Updated link * fix: image url Signed-off-by: Gil Fernandes <gil.fernandes@onepointltd.com>
Updated logo image URL