Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: image URL in README.md #6988

Merged
merged 7 commits into from Jul 27, 2020
Merged

Conversation

iamdarshshah
Copy link
Contributor

@iamdarshshah iamdarshshah commented Jul 12, 2020

Updated logo image URL

Screenshot:
Strapi

updated logo image URL
@codecov
Copy link

codecov bot commented Jul 12, 2020

Codecov Report

Merging #6988 into master will decrease coverage by 6.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6988      +/-   ##
==========================================
- Coverage   26.18%   20.05%   -6.13%     
==========================================
  Files        1130      858     -272     
  Lines       15404    12050    -3354     
  Branches     2435     1951     -484     
==========================================
- Hits         4033     2417    -1616     
+ Misses       9556     8062    -1494     
+ Partials     1815     1571     -244     
Flag Coverage Δ
#front 14.68% <ø> (-3.61%) ⬇️
#unit 42.45% <ø> (-10.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t-manager/admin/src/containers/EditView/reducer.js 0.00% <0.00%> (-100.00%) ⬇️
...manager/admin/src/containers/ListView/constants.js 0.00% <0.00%> (-100.00%) ⬇️
...t-manager/admin/src/containers/ListView/reducer.js 0.00% <0.00%> (-93.34%) ⬇️
...t-manager/admin/src/containers/ListView/actions.js 0.00% <0.00%> (-90.91%) ⬇️
...api-admin/admin/src/containers/AuthPage/reducer.js 0.00% <0.00%> (-85.72%) ⬇️
packages/strapi-utils/lib/sanitize-entity.js 5.55% <0.00%> (-55.74%) ⬇️
packages/strapi-utils/lib/config.js 13.51% <0.00%> (-51.36%) ⬇️
...strapi-admin/admin/src/containers/Admin/actions.js 50.00% <0.00%> (-50.00%) ⬇️
...strapi-admin/admin/src/containers/Admin/reducer.js 80.00% <0.00%> (-20.00%) ⬇️
packages/strapi-utils/lib/validators.js 88.88% <0.00%> (-6.95%) ⬇️
... and 539 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35bae7d...d45f6f7. Read the comment docs.

@alexandrebodin
Copy link
Member

Thanks @iamdarshshah, closing as the image is already up to date

@iamdarshshah
Copy link
Contributor Author

Hello @alexandrebodin

It looks like, the issue still exists. Can you please have a look at it again?

Screenshot
error

@lauriejim
Copy link
Contributor

Hum looks good on my side... The image is hosted on GitHub so that's weird.
Cache issue?

@iamdarshshah
Copy link
Contributor Author

@lauriejim It seems the issue is common across the different browsers. It could not be related to Cache. Maybe something else. Can you please share the screenshot?

Thanks 👍

@lauriejim
Copy link
Contributor

image
Just tried on my mobile - looks good.

@iamdarshshah
Copy link
Contributor Author

Okay, cool! No problem... If it works fine then there is no need for updating it. Still don't know why it's not working for me 😕

Will try to look for the solution to this issue. Anyways! Thank you 👍

@alexandrebodin
Copy link
Member

Let us know if this comes from a specific browser so we can fix it :D

@iamdarshshah
Copy link
Contributor Author

@alexandrebodin
I have tried with a different system and with different browsers. Here are the results:

I don't know what might be the reason behind this. The issue still exists across different browsers.

Screenshots:

1. Safari
Safari

2. Chrome
chrome

3. Opera
Opera

(P.S - Updated the PR info with a screenshot that includes changes that has been updated through this PR.)

@iamdarshshah
Copy link
Contributor Author

iamdarshshah commented Jul 27, 2020

This might happen due to the fact that Amazon AWS serves content to specific locations or rather I would say, It will work for certain locations only. It restricts data access to certain locations, this seems to be the reason for this issue. Due to which I can't access this particular file. Also, tried visiting current image URL directly and got this error as a response:

Response

We can update the URL by https://strapi.io/assets/strapi-logo.svg, which will directly point to the static files associated with the Strapi website. This will resolve this particular issue.

would appreciate your thoughts/ideas on this @lauriejim & @alexandrebodin

@alexandrebodin
Copy link
Member

@iamdarshshah You can actually use this one instead so it is the right one :D https://strapi.io/assets/strapi-logo-dark.svg

@iamdarshshah
Copy link
Contributor Author

iamdarshshah commented Jul 27, 2020

@alexandrebodin Sure, Updating that! But, need to reopen this PR to update the commit. Thanks 👍

@iamdarshshah
Copy link
Contributor Author

iamdarshshah commented Jul 27, 2020

@alexandrebodin Should I open new PR for updating image URL?

@alexandrebodin
Copy link
Member

@iamdarshshah I'll reopen this one so you can update 👍

@iamdarshshah
Copy link
Contributor Author

Thanks @alexandrebodin 👍 , I have updated the image URL. You can review it now :)

Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM THanks !

@alexandrebodin alexandrebodin added this to the 3.1.2 milestone Jul 27, 2020
@alexandrebodin alexandrebodin added source: docs Documentation changes issue: enhancement Issue suggesting an enhancement to an existing feature labels Jul 27, 2020
@alexandrebodin alexandrebodin merged commit 16b9185 into strapi:master Jul 27, 2020
Tomaszal pushed a commit to Tomaszal/strapi that referenced this pull request Jul 28, 2020
* Update README.md

updated logo image URL

* Updated link

* fix: image url

Signed-off-by: Tomaszal <mrtomaszal@gmail.com>
@iamdarshshah iamdarshshah deleted the patch-1 branch July 28, 2020 01:57
gilfernandes pushed a commit to onepointconsulting/strapi that referenced this pull request Aug 13, 2020
* Update README.md

updated logo image URL

* Updated link

* fix: image url

Signed-off-by: Gil Fernandes <gil.fernandes@onepointltd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants