Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update email.md #6997

Merged
merged 1 commit into from Jul 16, 2020
Merged

Conversation

sgauthiertremblay
Copy link
Contributor

Description of what you did:

Added the fact that if ./config/plugins.js file doesn't exists, we need to create it. It's not that obvious at first read.

@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #6997 into documentation will increase coverage by 0.84%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           documentation    #6997      +/-   ##
=================================================
+ Coverage          19.14%   19.98%   +0.84%     
=================================================
  Files                855      858       +3     
  Lines              11933    12097     +164     
  Branches            1898     1965      +67     
=================================================
+ Hits                2284     2418     +134     
+ Misses              8100     8094       -6     
- Partials            1549     1585      +36     
Flag Coverage Δ
#front 14.67% <ø> (+0.18%) ⬆️
#unit 41.71% <ø> (+1.77%) ⬆️
Impacted Files Coverage Δ
packages/strapi-plugin-email/admin/src/pluginId.js 0.00% <0.00%> (-100.00%) ⬇️
...n/src/containers/NotificationProvider/constants.js 0.00% <0.00%> (-100.00%) ⬇️
...n/admin/src/containers/LanguageProvider/reducer.js 0.00% <0.00%> (-61.54%) ⬇️
packages/strapi-utils/lib/stringFormatting.js 50.00% <0.00%> (-50.00%) ⬇️
packages/strapi-plugin-graphql/services/utils.js 24.69% <0.00%> (-11.03%) ⬇️
...min/src/containers/NotificationProvider/reducer.js 0.00% <0.00%> (-10.00%) ⬇️
.../admin/src/components/LeftMenuLink/LeftMenuIcon.js 50.00% <0.00%> (-7.15%) ⬇️
...strapi-plugin-upload/config/functions/bootstrap.js 62.06% <0.00%> (-6.69%) ⬇️
...api-admin/admin/src/components/PluginCard/index.js 4.87% <0.00%> (-2.27%) ⬇️
...trapi-admin/admin/src/containers/HomePage/hooks.js 5.00% <0.00%> (-0.89%) ⬇️
... and 160 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d707794...21ea1b2. Read the comment docs.

Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants