Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change preview for markdown-it in order to have all md support #7041

Merged
merged 4 commits into from Jul 20, 2020

Conversation

soupette
Copy link
Contributor

Signed-off-by: soupette cyril.lpz@gmail.com

Description of what you did:

Small update in order to change the markdown parser in order to improve the preview.
The preview is now very similar to this demo

Signed-off-by: soupette <cyril.lpz@gmail.com>
@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #7041 into features/rbac will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           features/rbac    #7041      +/-   ##
=================================================
- Coverage          25.68%   25.67%   -0.02%     
=================================================
  Files               1131     1131              
  Lines              15392    15399       +7     
  Branches            2428     2431       +3     
=================================================
  Hits                3953     3953              
- Misses              9605     9609       +4     
- Partials            1834     1837       +3     
Flag Coverage Δ
#front 18.26% <0.00%> (-0.02%) ⬇️
#unit 50.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ger/admin/src/components/PreviewWysiwyg/Wrapper.js 0.00% <0.00%> (ø)
...nager/admin/src/components/PreviewWysiwyg/index.js 0.00% <0.00%> (ø)
.../src/components/PreviewWysiwyg/utils/mdRenderer.js 0.00% <0.00%> (ø)
...rc/containers/EditViewDataManagerProvider/index.js 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd023c3...138f3bd. Read the comment docs.

Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:content-manager Source is core/content-manager package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants