Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker.md #7055

Closed
wants to merge 1 commit into from
Closed

Update docker.md #7055

wants to merge 1 commit into from

Conversation

Mic75
Copy link

@Mic75 Mic75 commented Jul 17, 2020

Strapi will fail to create the project in the folder complaing that the folder should be empty when strictly following the SQLite flavor of the Docker installation.

Adding an app subfolder and mounting from it fixes it.

Strapi will fail to create the project in the folder complaing that the folder should be empty when strictly following the doc.
Adding an `app` subfolder and mounting from it fixes the doc.

Signed-off-by: Mic75 <mat.benard@gmail.com>
@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #7055 into documentation will increase coverage by 0.91%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           documentation    #7055      +/-   ##
=================================================
+ Coverage          19.14%   20.05%   +0.91%     
=================================================
  Files                855      858       +3     
  Lines              11933    12050     +117     
  Branches            1898     1951      +53     
=================================================
+ Hits                2284     2417     +133     
+ Misses              8100     8062      -38     
- Partials            1549     1571      +22     
Flag Coverage Δ
#front 14.68% <ø> (+0.19%) ⬆️
#unit 42.45% <ø> (+2.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/strapi-plugin-email/admin/src/pluginId.js 0.00% <0.00%> (-100.00%) ⬇️
...n/src/containers/NotificationProvider/constants.js 0.00% <0.00%> (-100.00%) ⬇️
...n/admin/src/containers/LanguageProvider/reducer.js 0.00% <0.00%> (-61.54%) ⬇️
packages/strapi-utils/lib/stringFormatting.js 50.00% <0.00%> (-50.00%) ⬇️
packages/strapi-plugin-graphql/services/utils.js 24.69% <0.00%> (-11.03%) ⬇️
...min/src/containers/NotificationProvider/reducer.js 0.00% <0.00%> (-10.00%) ⬇️
.../admin/src/components/LeftMenuLink/LeftMenuIcon.js 50.00% <0.00%> (-7.15%) ⬇️
...strapi-plugin-upload/config/functions/bootstrap.js 62.06% <0.00%> (-6.69%) ⬇️
...api-admin/admin/src/components/PluginCard/index.js 4.87% <0.00%> (-2.27%) ⬇️
...trapi-admin/admin/src/containers/HomePage/hooks.js 5.00% <0.00%> (-0.89%) ⬇️
... and 162 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd710d3...09586d7. Read the comment docs.

@alexandrebodin
Copy link
Member

Hi @Mic75 thank you for your contribution. There is already an open PR for this that we just reviewed. it should be merged in the upcoming days :) I'm going to close this one to avoid duplicates :) You can check it out here: http://github.com/strapi/strapi/pull/6566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants