Upgrade apollo-server-koa #7087
Conversation
IkeLutra
force-pushed
the
upgrade-apollo-server-koa
branch
from
acc3340
to
647c152
Compare
|
I've forcefully retriggered the TravisCI PG test that failed. |
| @@ -12,7 +12,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@apollo/federation": "^0.15.0", | |||
| "apollo-server-koa": "2.9.12", | |||
| "apollo-server-koa": "^2.14.2", | |||
There was a problem hiding this comment.
Please make use of strict versions :)
There was a problem hiding this comment.
You mean like 2.14.2? I'm happy to chnage but can you explain the reasoning for strict versioning on just this dependency?
There was a problem hiding this comment.
@IkeLutra it is not specific to this package but we are taking every occasion to move to strict versions :) We have a PR to add dependabot PRs so we can get automated upgrades for thise kind of issues and still have stable versions so we don't break in unintended ways when dependecies break (which happened a few times already) Hope this helps
There was a problem hiding this comment.
Thanks that is really helpful. Just wanted to understand the reasoning that makes a lot of sense. Will update now 😄
Signed-off-by: Will Eldrid-Otterburn <will.eldrid-otterburn@red-badger.com>
Signed-off-by: Will Eldrid-Otterburn <will.eldrid-otterburn@red-badger.com>
IkeLutra
force-pushed
the
upgrade-apollo-server-koa
branch
from
895c17c
to
3da0eb0
Compare
alexandrebodin
added
source: plugin:graphql
* Upgrade apollo-server-koa Signed-off-by: Will Eldrid-Otterburn <will.eldrid-otterburn@red-badger.com> * Set apollo-server-koa to strict version Signed-off-by: Will Eldrid-Otterburn <will.eldrid-otterburn@red-badger.com> Co-authored-by: Alexandre BODIN <alexandrebodin@users.noreply.github.com> Signed-off-by: Gil Fernandes <gil.fernandes@onepointltd.com>
Description of what you did:
Updates
apollo-server-koato a version that fixes the security advisory in #7085