Remove flag in language selection

[better-owlet]

Flags are not languages

A blog about designing global user experiences: beyond language, location & culture.

[alexandrebodin]

Hello @anowlet thanks you for contributing !

Can you please add a short description so it is easy to understand what the PR is about ?

The article makes a lot of sense I think we need to consider removing the flag indeed :) We will check with our designer if we need ot change sth before merging this PR ;)

[alexandrebodin]

FYI design screenshot for design review.

[Aurelsicoko]

The acronym should be right-aligned, is it possible to update the PR then it looks good to me ;)

[soupette]

LGTM

[alexandrebodin]

@anowlet Any way you can make the update ?

[alexandrebodin]

Closing this PR for inactivity. Feel free to reopen if you get the time to update :)

[better-owlet]

http://www.flagsarenotlanguages.com/blog/why-flags-do-not-represent-language/

@alexandrebodin Flags are unique to a country or nation: but languages are often spoken across national borders. By using a flag for a language, you may confuse or even offend users.

[alexandrebodin]

@anowlet we totally agree we just need the PR to be updated according to the review (design update) before merging it. If you can do it we will reopen and merge 👍

Missing design fix

[codecov]

Codecov Report

Merging #7102 into master will decrease coverage by 0.08%.
The diff coverage is 2.56%.

@@            Coverage Diff             @@
##           master    #7102      +/-   ##
==========================================
- Coverage   26.23%   26.15%   -0.09%     
==========================================
  Files        1131     1131              
  Lines       15431    15426       -5     
  Branches     2442     2441       -1     
==========================================
- Hits         4048     4034      -14     
- Misses       9564     9573       +9     
  Partials     1819     1819              

Flag	Coverage Δ
#front	18.15% <2.56%> (-0.11%)	⬇️
#unit	53.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...admin/admin/src/containers/LocaleToggle/Wrapper.js	100.00% <ø> (ø)
...i-admin/admin/src/containers/LocaleToggle/index.js	100.00% <ø> (ø)
...-manager/admin/src/components/Wysiwyg/constants.js	0.00% <ø> (ø)
...nt-manager/admin/src/components/Wysiwyg/helpers.js	0.00% <0.00%> (ø)
...tent-manager/admin/src/components/Wysiwyg/index.js	0.00% <0.00%> (ø)
...ype-builder/admin/src/containers/ListView/index.js	0.00% <0.00%> (ø)
...iners/HomePage/HomePageContent/HomePageSettings.js	0.00% <ø> (ø)
...n/src/containers/HomePage/HomePageContent/index.js	0.00% <ø> (ø)
...ugin-upload/admin/src/containers/HomePage/index.js	0.00% <0.00%> (ø)
...in-upload/admin/src/containers/HomePage/reducer.js	65.85% <0.00%> (-15.97%)	⬇️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 817c46c...4a63ff1. Read the comment docs.

[better-owlet]

I think it should show the native name.

[alexandrebodin]

Can you please uppercase the first letter of the langageNativeNames when possible :)

[alexandrebodin]

@anowlet Thank you for this improvement 💯