Chore/ml delete assets #7109
Merged
Chore/ml delete assets #7109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: soupette <cyril.lpz@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #7109 +/- ##
==========================================
- Coverage 26.23% 26.16% -0.07%
==========================================
Files 1131 1130 -1
Lines 15431 15411 -20
Branches 2442 2435 -7
==========================================
- Hits 4048 4033 -15
+ Misses 9564 9563 -1
+ Partials 1819 1815 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
soupette
added
source: core:upload
HichamELBSI
requested changes
Jul 28, 2020
| @@ -333,11 +313,19 @@ const HomePage = () => { | |||
| ], | |||
| }; | |||
|
|
|||
| const handleRemoveFileFromDataToDelete = useCallback(id => { | |||
There was a problem hiding this comment.
Here, why do we need a useCallback ?
There was a problem hiding this comment.
It avoids rerenders
This was referenced Jun 6, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what you did:
Improve the delete asset workflow