New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/login providers #7132
Fix/login providers #7132
Conversation
07a8b38
to
3fce0be
Compare
Codecov Report
@@ Coverage Diff @@
## master #7132 +/- ##
==========================================
+ Coverage 26.17% 26.22% +0.05%
==========================================
Files 1130 1131 +1
Lines 15415 15433 +18
Branches 2439 2443 +4
==========================================
+ Hits 4035 4048 +13
- Misses 9561 9565 +4
- Partials 1819 1820 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
packages/strapi-plugin-users-permissions/admin/src/components/PopUpForm/index.js
Outdated
Show resolved
Hide resolved
3997497
to
d0f9ab6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the front-end part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3629809
to
d309feb
Compare
Is this PR ready to merge? |
I'm waiting for a review from @alexandrebodin |
d9c82c9
to
6aae7a6
Compare
Can you please target the |
@lauriejim this needs to be merged into master as there is code changes :) |
4f3fa4a
to
6aae7a6
Compare
6aae7a6
to
9871875
Compare
9871875
to
67a5402
Compare
Signed-off-by: Pierre Noël <petersg83@gmail.com>
Signed-off-by: Pierre Noël <petersg83@gmail.com>
Signed-off-by: Pierre Noël <petersg83@gmail.com>
Signed-off-by: Pierre Noël <petersg83@gmail.com>
Signed-off-by: Pierre Noël <petersg83@gmail.com>
67a5402
to
7729326
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm
Thank you for this @petersg83 works great |
Just tested it with the Github provider and replaceLoginApp branch login-React exaple. Notes: http://localhost:1337/admin/plugins/users-permissions/providers |
⚠ need to merge #7054 before
fix #7206
fix #6570
Should be be merged at the same time as: strapi/strapi-examples#164
NB:
I tested all providers. They all work except:
Thoses bugs need to be fixed, but not in this PR.