Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/login providers #7132

Merged
merged 6 commits into from Aug 4, 2020
Merged

Fix/login providers #7132

merged 6 commits into from Aug 4, 2020

Conversation

petersg83
Copy link
Contributor

@petersg83 petersg83 commented Jul 23, 2020

⚠ need to merge #7054 before
fix #7206
fix #6570

Should be be merged at the same time as: strapi/strapi-examples#164

  • Provider doc is updated
  • use of "redirect_url" is simplified in front

NB:
I tested all providers. They all work except:

  • twitter (the twitter user email was not given in the response api, so strapi can't match it with a strapi user)
  • instagram (the api is most likely outdated)
  • vk (api is outdated, min version is 5.21)

Thoses bugs need to be fixed, but not in this PR.

@petersg83 petersg83 changed the base branch from master to develop July 23, 2020 12:41
@petersg83 petersg83 changed the base branch from develop to master July 23, 2020 12:41
@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #7132 into master will increase coverage by 0.05%.
The diff coverage is 48.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7132      +/-   ##
==========================================
+ Coverage   26.17%   26.22%   +0.05%     
==========================================
  Files        1130     1131       +1     
  Lines       15415    15433      +18     
  Branches     2439     2443       +4     
==========================================
+ Hits         4035     4048      +13     
- Misses       9561     9565       +4     
- Partials     1819     1820       +1     
Flag Coverage Δ
#front 18.26% <0.00%> (-0.01%) ⬇️
#unit 53.14% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/strapi-admin/admin/src/containers/Admin/index.js 63.82% <ø> (ø)
...admin/admin/src/containers/Roles/EditPage/index.js 2.77% <0.00%> (-0.80%) ⬇️
...admin/admin/src/containers/Roles/ListPage/index.js 0.00% <0.00%> (ø)
...ermissions/admin/src/components/PopUpForm/index.js 0.00% <0.00%> (ø)
packages/strapi-admin/services/metrics.js 100.00% <100.00%> (ø)
packages/strapi-admin/services/role.js 94.11% <100.00%> (+0.14%) ⬆️
packages/strapi-admin/services/user.js 82.56% <100.00%> (+0.66%) ⬆️
packages/strapi/lib/services/metrics/sender.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8bb45d...7729326. Read the comment docs.

Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the front-end part

lauriejim
lauriejim previously approved these changes Jul 27, 2020
Copy link
Contributor

@lauriejim lauriejim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lauriejim
Copy link
Contributor

Is this PR ready to merge?

@petersg83
Copy link
Contributor Author

Is this PR ready to merge?

I'm waiting for a review from @alexandrebodin

alexandrebodin
alexandrebodin previously approved these changes Aug 3, 2020
@lauriejim
Copy link
Contributor

Can you please target the documentation branch.

@alexandrebodin
Copy link
Member

@lauriejim this needs to be merged into master as there is code changes :)

@petersg83 petersg83 changed the base branch from documentation to master August 3, 2020 12:37
@petersg83 petersg83 added source: docs Documentation changes source: plugin:users-permissions Source is plugin/users-permissions package issue: enhancement Issue suggesting an enhancement to an existing feature labels Aug 3, 2020
Signed-off-by: Pierre Noël <petersg83@gmail.com>
Signed-off-by: Pierre Noël <petersg83@gmail.com>
Signed-off-by: Pierre Noël <petersg83@gmail.com>
Signed-off-by: Pierre Noël <petersg83@gmail.com>
Signed-off-by: Pierre Noël <petersg83@gmail.com>
Signed-off-by: Pierre Noël <petersg83@gmail.com>
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm

@alexandrebodin alexandrebodin added this to the 3.1.4 milestone Aug 4, 2020
@alexandrebodin alexandrebodin merged commit 7113f7f into master Aug 4, 2020
@alexandrebodin alexandrebodin deleted the fix/loginProviders branch August 4, 2020 22:02
@derrickmehaffy
Copy link
Member

Thank you for this @petersg83 works great

@veerjainATgmail
Copy link

Just tested it with the Github provider and replaceLoginApp branch login-React exaple.
Works perfect.! Thanks. The login-React example is simpler now.

Notes:
If someone is facing github error "Authorization callback URL mismatch error", that means url is not mentioned in the config/server.js file. Pasting the snapshot for the working case.

http://localhost:1337/admin/plugins/users-permissions/providers
https://github.com/settings/applications
and, config/server.js - strapi server code.

image

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes source: plugin:users-permissions Source is plugin/users-permissions package
Projects
None yet
7 participants