Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upload api #7136

Merged
merged 1 commit into from Jul 23, 2020
Merged

Fix upload api #7136

merged 1 commit into from Jul 23, 2020

Conversation

alexandrebodin
Copy link
Member

@alexandrebodin alexandrebodin commented Jul 23, 2020

Fix #7131

@Convly you can add test for this

Signed-off-by: Alexandre Bodin <bodin.alex@gmail.com>
@alexandrebodin alexandrebodin added this to the 3.1.1 milestone Jul 23, 2020
@alexandrebodin alexandrebodin added source: core:upload Source is core/upload package issue: bug Issue reporting a bug labels Jul 23, 2020
Copy link
Contributor

@petersg83 petersg83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it, it fixes the issue 👌

@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #7136 into master will increase coverage by 6.13%.
The diff coverage is 44.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7136      +/-   ##
==========================================
+ Coverage   20.05%   26.18%   +6.13%     
==========================================
  Files         858     1130     +272     
  Lines       12049    15404    +3355     
  Branches     1951     2435     +484     
==========================================
+ Hits         2416     4033    +1617     
- Misses       8062     9556    +1494     
- Partials     1571     1815     +244     
Flag Coverage Δ
#front 18.28% <44.17%> (+3.60%) ⬆️
#unit 52.94% <ø> (+10.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...admin/admin/src/components/ContainerFluid/index.js 66.66% <0.00%> (-33.34%) ⬇️
...pi-admin/admin/src/components/GlobalStyle/index.js 0.00% <ø> (ø)
.../src/components/LeftMenu/LeftMenuFooter/Wrapper.js 60.00% <ø> (ø)
...in/src/components/LeftMenu/LeftMenuFooter/index.js 66.66% <ø> (ø)
.../src/components/LeftMenu/LeftMenuHeader/Wrapper.js 60.00% <ø> (ø)
...in/src/components/LeftMenu/LeftMenuHeader/index.js 50.00% <ø> (ø)
...in/admin/src/components/LeftMenu/LeftMenuLink/A.js 12.50% <ø> (ø)
...c/components/LeftMenu/LeftMenuLink/LeftMenuIcon.js 50.00% <ø> (ø)
...c/components/LeftMenu/LeftMenuLinkHeader/Search.js 50.00% <ø> (ø)
...onents/LeftMenu/LeftMenuLinkHeader/SearchButton.js 100.00% <ø> (ø)
... and 651 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fd98b0...e18c54b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:upload Source is core/upload package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload broken in 3.1.0
2 participants