Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7139 #7155

Merged
merged 1 commit into from Jul 24, 2020
Merged

Fixes #7139 #7155

merged 1 commit into from Jul 24, 2020

Conversation

soupette
Copy link
Contributor

Signed-off-by: soupette cyril.lpz@gmail.com

Description of what you did:

This PR fixes #7139

Signed-off-by: soupette <cyril.lpz@gmail.com>
@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #7155 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7155      +/-   ##
==========================================
- Coverage   26.18%   26.17%   -0.01%     
==========================================
  Files        1130     1130              
  Lines       15404    15406       +2     
  Branches     2435     2436       +1     
==========================================
  Hits         4033     4033              
- Misses       9556     9557       +1     
- Partials     1815     1816       +1     
Flag Coverage Δ
#front 18.28% <0.00%> (-0.01%) ⬇️
#unit 52.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ainers/EditViewDataManagerProvider/utils/schema.js 0.00% <0.00%> (ø)
...permissions/admin/src/components/EditForm/index.js 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb63652...a9387d4. Read the comment docs.

@ralphsomeday
Copy link
Contributor

@soupette boolean seems also to act in a weird way

Copy link
Contributor

@ralphsomeday ralphsomeday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are boolean also covered here?

@alexandrebodin alexandrebodin added this to the 3.1.2 milestone Jul 24, 2020
@alexandrebodin alexandrebodin added source: core:admin Source is core/admin package issue: bug Issue reporting a bug labels Jul 24, 2020
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin
Copy link
Member

@ralphsomeday This only addresses the issue with 0 not being considered as a value. no changes on boolean. But this is not mentionned in your model in the issue. You could always reopen a new one

@alexandrebodin alexandrebodin merged commit df7d7d4 into master Jul 24, 2020
@alexandrebodin alexandrebodin deleted the fix/7139 branch July 24, 2020 12:26
@ralphsomeday
Copy link
Contributor

Hi @alexandrebodin I did mention boolean :) 'Also when resetting a boolean to false is says value is required.' but no worries will test everything with the 3.1.2 and if still have an issue with boolean will open another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot save a content type using Strapi admin panel UI in 3.1.0
3 participants