New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #7139 #7155
Fixes #7139 #7155
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7155 +/- ##
==========================================
- Coverage 26.18% 26.17% -0.01%
==========================================
Files 1130 1130
Lines 15404 15406 +2
Branches 2435 2436 +1
==========================================
Hits 4033 4033
- Misses 9556 9557 +1
- Partials 1815 1816 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@soupette boolean seems also to act in a weird way |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are boolean also covered here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ralphsomeday This only addresses the issue with 0 not being considered as a value. no changes on boolean. But this is not mentionned in your model in the issue. You could always reopen a new one |
Hi @alexandrebodin I did mention boolean :) 'Also when resetting a boolean to false is says value is required.' but no worries will test everything with the 3.1.2 and if still have an issue with boolean will open another issue. |
Signed-off-by: soupette cyril.lpz@gmail.com
Description of what you did:
This PR fixes #7139