New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #7141 - Wrong conversion of to a boolean value #7161
Conversation
Signed-off-by: agigleux <alexandre.gigleux@sonarsource.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #7161 +/- ##
==========================================
- Coverage 26.23% 26.22% -0.01%
==========================================
Files 1131 1131
Lines 15431 15433 +2
Branches 2442 2438 -4
==========================================
Hits 4048 4048
- Misses 9564 9569 +5
+ Partials 1819 1816 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: agigleux <alexandre.gigleux@sonarsource.com> Co-authored-by: Alexandre BODIN <alexandrebodin@users.noreply.github.com> Signed-off-by: Gil Fernandes <gil.fernandes@onepointltd.com>
I replace all occurrences of:
const hasError = error && error !== null;
by
const hasError = Boolean(error);
yarn test:unit: OK
yarn test:front: OK