Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pluginsSectionLinks in plugin generator #7169

Merged
merged 1 commit into from Jul 28, 2020
Merged

Fix pluginsSectionLinks in plugin generator #7169

merged 1 commit into from Jul 28, 2020

Conversation

lauriejim
Copy link
Contributor

Description of what you did:

This PR fix #7162 - the plugin name was not displayed in the menu because the key was not well named.

@lauriejim
Fix #7162 - pluginsSectionLinks in plugin generator
410342c 
Signed-off-by: Jim LAURIE <j.laurie6993@gmail.com>
@lauriejim lauriejim added issue: bug Issue reporting a bug source: core:admin Source is core/admin package labels Jul 25, 2020
@lauriejim lauriejim requested a review from soupette July 25, 2020 13:26
soupette
soupette approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin alexandrebodin added this to the 3.1.2 milestone Jul 28, 2020
@alexandrebodin alexandrebodin merged commit 3e42365 into master Jul 28, 2020
@alexandrebodin alexandrebodin deleted the fix-7162 branch July 28, 2020 08:39
gilfernandes pushed a commit to onepointconsulting/strapi that referenced this pull request Aug 13, 2020
@lauriejim @onepointconsulting
Fix strapi#7162 - pluginsSectionLinks in plugin generator (strapi#7169)
1dbe89f 
Signed-off-by: Jim LAURIE <j.laurie6993@gmail.com>
Signed-off-by: Gil Fernandes <gil.fernandes@onepointltd.com>
This was referenced Jun 6, 2021
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soupette soupette soupette approved these changes

Assignees
No one assigned
Labels
issue: bug Issue reporting a bug source: core:admin Source is core/admin package
Projects
None yet
Milestone
3.1.2
Development

Successfully merging this pull request may close these issues.

Bug when creating custom plugin : bad config for menu
3 participants
@lauriejim @soupette @alexandrebodin