Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Input Number issue #7178

Merged
merged 3 commits into from Jul 29, 2020
Merged

Fix Input Number issue #7178

merged 3 commits into from Jul 29, 2020

Conversation

ericliu-el
Copy link
Contributor

@ericliu-el ericliu-el commented Jul 26, 2020 •
edited

Signed-off-by: Eric Liu eric@ericliu.page

Description of what you did:

fix strapi/buffet#136

  1. Changing from 'text' to 'number' input for 'biginteger'. So it will show the inc/dec arrows for bigingeter input.
  2. Set 'step' to 0.1 instead of 'any' so the inc/dec arrows on Decimal and Float type can work properly.
  3. Changing 'step' value to the specific number type

@ericliu-el
fix Input Number issue
e099889 
Signed-off-by: Eric Liu <eric@ericliu.page>
@derrickmehaffy
Copy link
Member

Changing the bigint will cause issues as js has very low support of big int at the moment, you will get rounding hence why it's so to string

@ericliu-el
Copy link
Contributor Author

Thanks @derrickmehaffy
I have changed it back to text

soupette
soupette approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soupette soupette added source: core:content-manager Source is core/content-manager package issue: bug Issue reporting a bug labels Jul 28, 2020
@soupette soupette added this to the 3.1.2 milestone Jul 28, 2020
HichamELBSI
HichamELBSI approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@HichamELBSI HichamELBSI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin alexandrebodin merged commit 0ea63e0 into strapi:master Jul 29, 2020
@ericliu-el ericliu-el deleted the fix-Input-Number-issue branch July 29, 2020 22:32
@novades
Copy link

novades commented Aug 7, 2020 •
edited

This change breaks fields used as latitude/longitude

Captura de pantalla 2020-08-07 a las 18 08 54

@Un1xG0d Un1xG0d mentioned this pull request Aug 19, 2020
Closed
@Arsfiqball
Copy link

I'm experiencing same issue as @novades has. This changes affects other components.

@HichamELBSI
Copy link
Contributor

Hi @Arsfiqball, which one?

@Arsfiqball
Copy link

Oh sorry @HichamELBSI my bad, just figured out that float and decimal uses same component. It only occur in Firefox btw.

This was referenced Jun 6, 2021
Closed
Closed
Closed
Closed
@ebarahona ebarahona mentioned this pull request Nov 15, 2023
Open
This was referenced Nov 30, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HichamELBSI HichamELBSI HichamELBSI approved these changes

@soupette soupette soupette approved these changes

Assignees
No one assigned
Labels
issue: bug Issue reporting a bug source: core:content-manager Source is core/content-manager package
Projects
None yet
Milestone
3.1.2
Development

Successfully merging this pull request may close these issues.

Input number in Content-Type Manager is broken for bigInteger, decimal and float
7 participants
@ericliu-el @derrickmehaffy @novades @Arsfiqball @HichamELBSI @soupette @alexandrebodin