Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mailgun provider README #7190

Merged
merged 1 commit into from Jul 27, 2020
Merged

Conversation

dmgallardo
Copy link
Contributor

Added extra settings on the mailgun config based on the mailgun usage overview.
You can check the doc, and it specify the domain parameter.
https://www.npmjs.com/package/mailgun-js#usage-overview

You need to specify the domain, otherwise the email won't be sent, but the API return success anyway.
In my scenario I have a mailgun account with multiple domains and without this param the email was not sent. Don't know if a mailgun with a single domain works.

cc @alexandrebodin

Added extra settings on the mailgun config based on the mailgun usage overview.
You can check the doc, and it specify the domain parameter.
https://www.npmjs.com/package/mailgun-js#usage-overview

You need to specify the domain, otherwise the email won't be sent, but the API return success anyway. 
In my scenario I have a mailgun account with multiple domains and without this param the email was not sent. Don't know if a mailgun with a single domain works.
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement

@alexandrebodin alexandrebodin added this to the 3.1.2 milestone Jul 27, 2020
@alexandrebodin alexandrebodin added source: docs Documentation changes issue: enhancement Issue suggesting an enhancement to an existing feature labels Jul 27, 2020
@alexandrebodin alexandrebodin merged commit 2542cea into strapi:master Jul 27, 2020
@alexandrebodin alexandrebodin changed the title Update README.md Update mailgun provider README Jul 27, 2020
juandl pushed a commit to juandl/strapi that referenced this pull request Jul 27, 2020
Added extra settings on the mailgun config based on the mailgun usage overview.
You can check the doc, and it specify the domain parameter.
https://www.npmjs.com/package/mailgun-js#usage-overview

You need to specify the domain, otherwise the email won't be sent, but the API return success anyway.
In my scenario I have a mailgun account with multiple domains and without this param the email was not sent. Don't know if a mailgun with a single domain works.

Signed-off-by: Juan David <juand.business@gmail.com>
gilfernandes pushed a commit to onepointconsulting/strapi that referenced this pull request Aug 13, 2020
Added extra settings on the mailgun config based on the mailgun usage overview.
You can check the doc, and it specify the domain parameter.
https://www.npmjs.com/package/mailgun-js#usage-overview

You need to specify the domain, otherwise the email won't be sent, but the API return success anyway. 
In my scenario I have a mailgun account with multiple domains and without this param the email was not sent. Don't know if a mailgun with a single domain works.

Signed-off-by: Gil Fernandes <gil.fernandes@onepointltd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants