Fix date and datetime required validations issue #7198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: soupette <cyril.lpz@gmail.com>
soupette
added
source: core:content-manager
Codecov Report
@@ Coverage Diff @@
## master #7198 +/- ##
==========================================
- Coverage 26.17% 26.17% -0.01%
==========================================
Files 1130 1130
Lines 15406 15410 +4
Branches 2436 2438 +2
==========================================
Hits 4033 4033
- Misses 9557 9559 +2
- Partials 1816 1818 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
alexandrebodin
approved these changes
Jul 27, 2020
@alexandrebodin this should fix it :)! thanks. I guess you will be releasing it in 3.1.2, right? |
|
Just updated to 3.1.2. Issue with required boolean values remains as described above. |
|
@pjamieson did you rebuild your admin ? |
|
Yes. I have both re-installed with yarn and rebuilt Strapi with yarn develop. (And I see the same issue in a production build.)
Originally, I was running 3.0.5, and did not have this issue with the required boolean values. The problem started when I updated to 3.1.1, and remains after updating to 3.1.2.
When I initially try to save an update, the boolean values (I have 3 required boolean values in this case) are flagged as required in the UI, even though they were previously set and have not been touched. Toggling them makes the warning in the Admin UI go away, but saving still does not work, and validation errors still appear in the Chrome Dev Tools.
FYI, in one case (with v3.1.1) a required decimal value (for a price) appeared to exhibit the same problem even though it already had a previously entered valid entry of 0.00. I have not dug into that one, as I have been focused on the booleans.
Thanks for looking into this.
Patrick Jamieson
… On Jul 30, 2020, at 12:42 AM, Alexandre BODIN ***@***.***> wrote:
@pjamieson <https://github.com/pjamieson> did you rebuild your admin ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#7198 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADT5HKVBJ37EW3WYSTIR4DR6EP5FANCNFSM4PISXIZA>.
|
This was referenced Jun 6, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: soupette cyril.lpz@gmail.com
Description of what you did:
This PR fixes the required validation issue when updating a entry that has a required date field.