Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the CheatSheet link #7213

Merged
merged 1 commit into from Jul 29, 2020
Merged

Add the CheatSheet link #7213

merged 1 commit into from Jul 29, 2020

Conversation

Mcastres
Copy link
Contributor

Description of what you did:

Added a link to our Cheatsheet in the bottom right blue button (?).

@Mcastres Mcastres requested a review from soupette July 27, 2020 16:37
@Mcastres
Add the CheatSheet link
636c7d3 
Signed-off-by: Maxime Castres <mcastres@student.42.fr>
@codecov
Copy link

codecov bot commented Jul 27, 2020 •
edited

Codecov Report

Merging #7213 into master will increase coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7213   +/-   ##
=======================================
  Coverage   26.17%   26.18%           
=======================================
  Files        1130     1130           
  Lines       15410    15408    -2     
  Branches     2438     2436    -2     
=======================================
+ Hits         4033     4034    +1     
+ Misses       9559     9558    -1     
+ Partials     1818     1816    -2
Flag Coverage Δ
#front 18.28% <0.00%> (+<0.01%) ⬆️
#unit 52.96% <50.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...min/src/containers/Onboarding/StaticLinks/index.js 0.00% <0.00%> (ø)
packages/strapi-provider-upload-local/lib/index.js 26.08% <50.00%> (+3.35%) ⬆️
...ainers/EditViewDataManagerProvider/utils/schema.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c40d21...636c7d3. Read the comment docs.

soupette
soupette approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soupette soupette added the issue: enhancement Issue suggesting an enhancement to an existing feature label Jul 28, 2020
@soupette soupette added this to the 3.1.2 milestone Jul 28, 2020
@soupette soupette added the source: core:admin Source is core/admin package label Jul 28, 2020
@alexandrebodin alexandrebodin merged commit b4c4307 into master Jul 29, 2020
@alexandrebodin alexandrebodin deleted the features/CheatSheet_link branch July 29, 2020 11:28
gilfernandes pushed a commit to onepointconsulting/strapi that referenced this pull request Aug 13, 2020
@Mcastres @onepointconsulting
Add the CheatSheet link (strapi#7213)
e751441 
Signed-off-by: Maxime Castres <mcastres@student.42.fr>
Signed-off-by: Gil Fernandes <gil.fernandes@onepointltd.com>
This was referenced Jun 6, 2021
Closed
Closed
Closed
Closed
@ebarahona ebarahona mentioned this pull request Nov 15, 2023
Open
This was referenced Nov 30, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soupette soupette soupette approved these changes

Assignees
No one assigned
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:admin Source is core/admin package
Projects
None yet
Milestone
3.1.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mcastres @soupette @alexandrebodin