Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CE tests for travis #7218

Merged
merged 4 commits into from Jul 29, 2020
Merged

Fix CE tests for travis #7218

merged 4 commits into from Jul 29, 2020

Conversation

alexandrebodin
Copy link
Member

@alexandrebodin alexandrebodin commented Jul 27, 2020

Signed-off-by: Alexandre Bodin bodin.alex@gmail.com

Description of what you did:

Fix fork test to run CE tests only

FIx #7157

Signed-off-by: Alexandre Bodin <bodin.alex@gmail.com>
@alexandrebodin alexandrebodin added this to the 3.1.2 milestone Jul 28, 2020
@alexandrebodin alexandrebodin added issue: enhancement Issue suggesting an enhancement to an existing feature source: tooling Source is GitHub tooling/tests/ect labels Jul 28, 2020
Signed-off-by: Alexandre Bodin <bodin.alex@gmail.com>
Copy link
Contributor

@petersg83 petersg83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions :)

.travis.yml Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #7218 into master will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7218   +/-   ##
=======================================
  Coverage   26.17%   26.17%           
=======================================
  Files        1130     1130           
  Lines       15410    15411    +1     
  Branches     2438     2438           
=======================================
+ Hits         4033     4034    +1     
  Misses       9559     9559           
  Partials     1818     1818           
Flag Coverage Δ
#front 18.27% <ø> (ø)
#unit 52.96% <50.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/strapi-provider-upload-local/lib/index.js 26.08% <50.00%> (+3.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c40d21...811c73f. Read the comment docs.

petersg83
petersg83 previously approved these changes Jul 29, 2020
Copy link
Contributor

@petersg83 petersg83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Signed-off-by: Alexandre Bodin <bodin.alex@gmail.com>
@alexandrebodin alexandrebodin merged commit 7394a35 into master Jul 29, 2020
@alexandrebodin alexandrebodin deleted the chore/tests-ee-ce branch July 29, 2020 11:28
gilfernandes pushed a commit to onepointconsulting/strapi that referenced this pull request Aug 13, 2020
* Fix CE tests for travis

Signed-off-by: Alexandre Bodin <bodin.alex@gmail.com>

* Start app in CE too

Signed-off-by: Alexandre Bodin <bodin.alex@gmail.com>

* Cleanup

Signed-off-by: Alexandre Bodin <bodin.alex@gmail.com>
Signed-off-by: Gil Fernandes <gil.fernandes@onepointltd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: tooling Source is GitHub tooling/tests/ect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Travis builds are failing for PR's made from forks
2 participants