Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix server not accessible at bootstrap #7222

Merged
merged 1 commit into from Jul 28, 2020
Merged

Conversation

alexandrebodin
Copy link
Member

Signed-off-by: Alexandre Bodin bodin.alex@gmail.com

Description of what you did:

Fix #5869

Signed-off-by: Alexandre Bodin <bodin.alex@gmail.com>
@alexandrebodin alexandrebodin added this to the 3.1.2 milestone Jul 28, 2020
@alexandrebodin alexandrebodin added source: core:strapi Source is core/strapi package issue: bug Issue reporting a bug labels Jul 28, 2020
@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #7222 into master will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7222   +/-   ##
=======================================
  Coverage   26.17%   26.17%           
=======================================
  Files        1130     1130           
  Lines       15410    15411    +1     
  Branches     2438     2438           
=======================================
+ Hits         4033     4034    +1     
  Misses       9559     9559           
  Partials     1818     1818           
Flag Coverage Δ
#front 18.27% <ø> (ø)
#unit 52.96% <50.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/strapi-provider-upload-local/lib/index.js 26.08% <50.00%> (+3.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c40d21...cbc3e22. Read the comment docs.

@alexandrebodin alexandrebodin changed the title Fix server not accessible at boostrapi Fix server not accessible at bootstrap Jul 28, 2020
Copy link
Contributor

@petersg83 petersg83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:strapi Source is core/strapi package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't access strapi.server in bootstrap.js file
2 participants